Skip to content

feat(instance): migrate placement-group resource to API v2 - #6132

Open
Mia-Cross wants to merge 8 commits into
mainfrom
instance_v2_placement_group
Open

feat(instance): migrate placement-group resource to API v2#6132
Mia-Cross wants to merge 8 commits into
mainfrom
instance_v2_placement_group

Conversation

@Mia-Cross

@Mia-Cross Mia-Cross commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

This PR is a duplicate from #6117, which was from a fork.
Review comments are on the original PR.

@Mia-Cross Mia-Cross self-assigned this Sep 4, 2026
@Mia-Cross Mia-Cross added enhancement instance Instance issues, bugs and feature requests priority:high New features labels Sep 4, 2026
@codecov-commenter

codecov-commenter commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.43147% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.77%. Comparing base (f969501) to head (1886049).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...spaces/instance/v2alpha1/custom_placement_group.go 92.04% 7 Missing ⚠️
core/cobra_builder.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6132      +/-   ##
==========================================
- Coverage   50.78%   50.77%   -0.02%     
==========================================
  Files         359      361       +2     
  Lines       82302    82426     +124     
==========================================
+ Hits        41800    41848      +48     
- Misses      40502    40578      +76     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross
Mia-Cross force-pushed the instance_v2_placement_group branch from 4436b86 to 26c2711 Compare September 8, 2026 12:32
@Mia-Cross
Mia-Cross marked this pull request as ready for review September 8, 2026 14:28
@Mia-Cross
Mia-Cross requested review from a team and remyleone as code owners September 8, 2026 14:28
Comment thread internal/namespaces/instance/v1/custom_placement_group.go
pypaut
pypaut previously approved these changes Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement instance Instance issues, bugs and feature requests priority:high New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants