update SingleSelectOperator - #903
Open
SkywalkerSpace wants to merge 1 commit into
Open
Conversation
seafile-dev
reviewed
Aug 14, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
结论：Comment
Warnings：
- 单选值包含单引号的
IS条件已改为调用统一转义逻辑；但本 PR 未加入回归测试（见行内评论）。
Suggested fix: 为SingleSelectOperator.op_is增加包含单个和多个单引号的断言，并验证生成的 SQL 使用''。
| self.column_name, | ||
| '=', | ||
| filter_term | ||
| self.escape_string(filter_term) |
There was a problem hiding this comment.
[Warning] 缺少单引号回归测试
Why this matters:
本次修复专门处理选项名称中的单引号，但 PR 没有覆盖该场景；以后调整 op_is 或转义规则时，French a'c 仍可能再次生成无法解析的 SQL 并在图表中变成 500。
Suggested fix: 为 SingleSelectOperator.op_is 增加含一个及多个单引号的测试，断言 SQL 字面量使用 ''，例如 French a''c。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.