Repository navigation
Feature: Show URL and allow to inspect certificate in browser windows - #791
Merged
Merged
Conversation
sharkwouter
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #282
This PR tackles an issue that has been open since quite long ago:
Security concerns raised by folks at Debian.
Loginwindow (thinking about potential future use to open the GOG store from within MG). This step comes with a minor change in class composition: Gtk doesn't allow to inherit from templated classes. SoLoginis not a subclass ofDialoganymore, but a proxy exposing a similar api that internally configures and launches aBrowserWindow.Browserclass shows the URL, and a little icon (using stock namesystem-lock-screen, which should appear to be a lock)Maybe it's not the most beatiful solution out there, but it helps.
I'm a bit unsure about the icon in use, maybe we should either search another one to include in our resources, OR use another standard? Maybe one of
security-[high|medium|low](which appear to be little shield icons).Checklist