Repository navigation
Retry FW Lite update check after a failed fetch - #2729
Open
hahn-kev-bot wants to merge 2 commits into
Open
hahn-kev-bot wants to merge 2 commits into
hahn-kev-bot wants to merge 2 commits into
Conversation
A request that never reached the server (offline, DNS still down while a VPN connects) used to count as an update check, so the next attempt was UpdateCheckInterval (8h) away. Only record the check and populate the manual-check cache when the server actually answered, and re-run the check from ConnectivitySyncTrigger when internet access returns. The FW_LITE_CHAOS handler now also covers the "Lexbox" client used by the update check, injects the HttpRequestException/SocketException(11001) shape seen in the field, and accepts a numeric injection rate so a specific failure is reproducible instead of a dice roll. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
💻 FW Lite
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
… record malformed replies - TryUpdate takes a lock so the startup check and a connectivity-regained retry cannot both pass the throttle and apply the same update twice. - FwLiteWeb's NetworkChangeSyncTrigger retries the update check when the network comes back, matching the MAUI trigger. - Only a request that never got a response skips the throttle record; a response we fail to read or parse still counts as a check. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if something blocks the update check (no internet for example), then it won't retry for another 8 hours. It should retry next startup or if internet comes back.
AI summary
A field log showed FW Lite launched while a VPN was still connecting: DNS was dead for about 75 seconds, the update check failed with
No such host is known, and the app then treated that as a completed check, so it did not try again for the 8-hourUpdateCheckInterval.UpdateChecker.CheckForUpdateonly records the check and populates the 2-minute manual-check cache when the server actually answered. A server error response still counts as a check; a request that never reached the server does not.ConnectivitySyncTriggerre-runsTryUpdate()when network access transitions intoInternet, alongside re-establishing push listeners. The throttle still gates it.FW_LITE_CHAOShandler now also covers theLexboxclient used by the update check, adds anHttpRequestExceptionwrappingSocketException(HostNotFound)fault (the shape seen in the field), and accepts a numeric injection rate (FW_LITE_CHAOS=1.0) so a failure is reproducible.truestill means 30%..claude/launch.jsongainsviewer-devandfw-lite-web-chaosentries for running that repro from the Claude desktop app.Test plan
dotnet test backend/FwLite/FwLiteShared.Tests --filter FullyQualifiedName~UpdateCheckerTests(11 pass, 3 new: failed fetch does not record or cache and retries; successful response records and caches; server error still records)FW_LITE_CHAOS=1.0andUpdateCheckCondition=Always: startup update check and OIDC discovery both fail with the injectedNo such host is knownfault, matching the field log🤖 Generated with Claude Code