Repository navigation
Split custom view, media and comment APIs out of CrdtMiniLcmApi - #2731
Merged
Merged
Conversation
Move the custom view, media and comment implementations into CrdtCustomViewApi, CrdtMediaApi and CrdtCommentApi, leaving CrdtMiniLcmApi forwarding to them like the other split-out regions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
🔩 FW Lite Core
2 tasks done
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
hahn-kev
added this pull request to stack #2735
October 7, 2026 06:53
hahn-kev
added
the
self-reviewed 👁️
hahn-kev
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI summary
Continues splitting
CrdtMiniLcmApiinto sub-services inLcmCrdt/MiniLcmImp/, following the pattern of the existing writing system, part of speech, publication and other services.CrdtCustomViewApi: custom view CRUD and the manager-role checkCrdtMediaApi:GetFileStreamandSaveFileCrdtCommentApi: comment threads, user comments and the read-status pass-throughsCrdtMiniLcmApinow forwards these regions, and no longer takesLcmMediaServiceorLocalCommentReadStatusServiceLcmCrdtKernelMethod bodies were moved as they were, with no behaviour change. The only observable difference is that errors from
SaveFileare now logged under theCrdtMediaApicategory instead ofCrdtMiniLcmApi.This is the first of a stack. Later PRs will split out pictures, senses, example sentences and entries.
Test plan
LcmCrdt.Tests:CommentTests,CustomViewTests,MediaTests,ConfigRegistrationTestspass🤖 Generated with Claude Code