Repository navigation
Conversation
Move the entry methods, including CreateEntry and BulkCreateEntries, into CrdtEntryApi. CrdtMiniLcmApi is now a pure facade that forwards every IMiniLcmApi member to a sub-service. BulkCreateBatchSize moves with BulkCreateEntries, so BulkCreateEntriesTest sets it on the scoped CrdtEntryApi instead of on the facade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hahn-kev
added this pull request to stack #2735
October 7, 2026 07:43
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
hahn-kev
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI summary
Summary
Stacked on #2734. This is the last PR in the stack: it moves the entry methods into
CrdtEntryApi, after whichCrdtMiniLcmApionly forwards calls.LcmCrdt/ ├── CrdtMiniLcmApi.cs # 1173 → 690 lines, forwarders only └── MiniLcmImp/ ├── CrdtCommentApi.cs # #2731 ├── CrdtCustomViewApi.cs # #2731 ├── CrdtMediaApi.cs # #2731 ├── CrdtPictureApi.cs # #2732 ├── CrdtSenseApi.cs # #2733 ├── CrdtExampleSentenceApi.cs # #2734 + └── CrdtEntryApi.cs # Count/Get/Search/GetEntryIndex, Create, BulkCreate, Update ×2, DeleteMethod bodies were moved unchanged. Other details:
IsEntryDeletedmoves together with the commented-out checks inCreateEntrythat reference it.BulkCreateBatchSizemoves toCrdtEntryApi, andBulkCreateEntriesTestnow sets it on the scopedCrdtEntryApi. That is the same instance the facade uses, so the tests still exercise multi-batch flushes.EntrySearchService?parameter was carried over as it is.EntrySearchServiceis never registered in DI (onlyEntrySearchServiceFactoryis), so the parameter is always null and the search-table regenerate after a bulk import never runs. That was already true before this PR, and a separate follow-up will investigate it.Merge Danger
Door: two-way
This is a code move with no change in behaviour, so a revert is clean.
Blast Radius: logging
The bulk-import progress logs ("Added {Count} entries") now come from the
CrdtEntryApilogger category instead ofCrdtMiniLcmApi. Every other behaviour is unchanged.Evidence
LcmCrdt.Tests: 246 passed. IncludesBulkCreateEntriesTests,CreateEntryTests,UpdateEntryTests,QueryEntryTests,EntryIndexTests,HomographNumberTests,SortingTests,BasicApiTests,ComplexFormComponentTests,ConfigRegistrationTests.FwLiteProjectSync.Tests: 61 of 62 passed acrossSyncTests,ImportTests,CrdtEntrySyncTestsandSena3SyncTests.ImportsANewlyCreatedWritingSystem, happens only on Windows and has nothing to do with this PR. FwData ignores the font passed toCreateWritingSystemand uses liblcm's per-language default, which is "Charis" on Windows and "Charis SIL" on Linux (see the comment inSena3SyncTests). No PR in this stack touches writing system or FwData code.🤖 Generated with Claude Code