Repository navigation
Conversation
…econnecting Backends register their user-message and RPC handlers once, on the offline stub when the server is unreachable at startup. The real session that replaces it never got them, so app messages, abort and kill were ignored.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary. When a session starts while the server is unreachable, its message and RPC handlers (abort, kill) are registered on the offline stub. After reconnecting, the real session replaces the stub without them, so messages from the app, Stop and kill are ignored. This PR has the offline stub record those registrations, and
setupOfflineReconnectionattaches them to the real session before swapping it in. Fixes #1857.Changes
utils/offlineSessionStub.ts: the stub records the latestonUserMessagehandler and everyregisterHandlercall; addstransferOfflineRegistrations(stub, session).utils/setupOfflineReconnection.ts: calls it on reconnect, beforeonSessionSwap.utils/setupOfflineReconnection.test.ts: 4 new tests. All fail onmainand pass with this change.Proof
No new failures across the wire, server, app, CLI and agent test suites.
Related: #1293.