Repository navigation
Conversation
info.tsx imports navigateToSession since 051c228, which loads expo-constants through track; unmocked, the test file fails to load with '__DEV__ is not defined'.
Contributor
|
Reproduced and verified on current
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary.
sources/components/sessionPresentation.test.tsno longer loads: since 051c228,session/[id]/info.tsximportsnavigateToSessionfrom@/hooks/useNavigateToSession, which imports@/track→expo-constants→expo-modules-core, and that fails under vitest withReferenceError: __DEV__ is not defined. None of the file's 19 tests run. CI does not run the app's unit tests, so it went unnoticed. This PR mocks@/hooks/useNavigateToSessionin the test, like its other hook mocks.Proof (
pnpm --filter happy-app exec vitest run sources/components/sessionPresentation.test.ts)Full app suite on this branch: 171 files, 1946 passed, 1 skipped.