[BCF-3048] - Chain reader event querying - #12486
Merged
Merged
Conversation
…-querying # Conflicts: # core/chains/evm/logpoller/orm.go
…-querying # Conflicts: # core/scripts/go.mod # core/scripts/go.sum # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.mod # integration-tests/load/go.sum
…-querying # Conflicts: # core/scripts/go.mod # core/scripts/go.sum # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.mod # integration-tests/load/go.sum
…-querying # Conflicts: # core/chains/evm/forwarders/forwarder_manager.go # core/chains/evm/logpoller/disabled.go # core/chains/evm/logpoller/log_poller.go # core/chains/evm/logpoller/mocks/log_poller.go # core/chains/evm/logpoller/observability.go # core/chains/evm/logpoller/orm.go # core/chains/evm/logpoller/orm_test.go # core/scripts/go.mod # core/scripts/go.sum # core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/registry.go # core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/registry_check_pipeline_test.go # core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/registry_test.go # core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/upkeepstate/scanner.go # core/services/ocr2/plugins/ocr2vrf/coordinator/coordinator.go # core/services/ocr2/plugins/ocr2vrf/coordinator/coordinator_test.go # core/services/relay/evm/chain_reader.go # core/services/relay/evm/event_binding.go # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.mod # integration-tests/load/go.sum
jmank88
reviewed
Mar 19, 2024
ilija42
requested review from
a team,
archseer,
austinborn,
bolekk and
patrick-dowell
as code owners
May 6, 2024 15:55
ilija42
commented
May 7, 2024
| } | ||
|
|
||
| func NewFinalityFilter(filter *primitives.Confirmations) (query.Expression, error) { | ||
| // TODO chain agnostic confidence levels that map to evm finality |
Contributor
Author
There was a problem hiding this comment.
adressed here smartcontractkit/chainlink-common#494
EasterTheBunny
previously approved these changes
May 7, 2024
…-querying2 # Conflicts: # core/services/relay/evm/chain_reader.go
|
mateusz-sekara
approved these changes
May 8, 2024
ilija42
enabled auto-merge
May 8, 2024 13:25
EasterTheBunny
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate PRs will handle:
Related PRs: