Add CrossDomainGovernor contract - #5217
Merged
Merged
Conversation
Contributor
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
added 2 commits
October 12, 2021 21:48
yosriady
marked this pull request as ready for review
October 12, 2021 13:57
yosriady
requested review from
alexroan,
connorwstein and
se3000
as code owners
October 12, 2021 13:57
yosriady
marked this pull request as draft
October 19, 2021 13:19
yosriady
force-pushed
the
feature/arbitrum-forwarder-delegate
branch
from
October 19, 2021 13:28
2bb39ff to
434339e
Compare
yosriady
force-pushed
the
feature/arbitrum-forwarder-delegate
branch
from
October 19, 2021 13:32
434339e to
b4784c8
Compare
yosriady
marked this pull request as ready for review
October 19, 2021 17:32
added 2 commits
October 20, 2021 01:33
yosriady
force-pushed
the
feature/arbitrum-forwarder-delegate
branch
from
October 21, 2021 13:19
d2889c7 to
18756d5
Compare
yosriady
force-pushed
the
feature/arbitrum-forwarder-delegate
branch
from
October 22, 2021 12:38
a662824 to
ee81c30
Compare
Contributor
Author
|
@krebernisak I've updated the original PR to address your feedback. It now leaves the Instead, the new |
yosriady
force-pushed
the
feature/arbitrum-forwarder-delegate
branch
from
November 29, 2021 15:06
42c4594 to
876aa0e
Compare
Contributor
Author
|
@krebernisak @se3000 All of the audit feedback has been addressed so I believe we can merge this. Please have another look, thank you. |
yosriady
force-pushed
the
feature/arbitrum-forwarder-delegate
branch
from
January 27, 2022 05:51
cd466a4 to
87e1914
Compare
yosriady
force-pushed
the
feature/arbitrum-forwarder-delegate
branch
2 times, most recently
from
January 27, 2022 07:38
675a787 to
018b4e3
Compare
yosriady
force-pushed
the
feature/arbitrum-forwarder-delegate
branch
from
January 27, 2022 07:50
018b4e3 to
382276d
Compare
krebernisak
requested changes
Jan 27, 2022
krebernisak
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Governorcontract in this PR will own contracts on L2 (similar toTimelock, if you're familiar with that) to mitigate any L2-specific risks.This PR
This PR adds a
CrossDomainGovernorcontract for Arbitrum (and Optimism.)The
Forwardercontract is used to receive cross-chain messages from L1 and acts as the owner of L2 contracts.It implements a new
forwardDelegatefunction is used to forwardMultisendtransactions on L2, which can only be triggered by adelegatecallfrom the Forwarder contract. We useMultisendtransactions for our batch Safe proposals.Here's a diagram how the
Forwarder/Governorcontract is used alongsideMultisendon L2: