[1.7.0] Fix merge conflicts with develop - #7201
Closed
HenryNguyen5 wants to merge 77 commits into
Closed
Conversation
HenryNguyen5
commented
Aug 9, 2022
HenryNguyen5
commented
Contributor
- Pretty format bigint upkeepID
- Reshuffle erroneous changelog entries from 1.6 to unreleased (Reshuffle erroneous changelog entries from 1.6 to unreleased #7092)
- OCR2 test flake fix - bootstrap replay (OCR2 test flake fix - ensure bootstrap has config log #7096)
- fix: add StarknetNodes to config schema (fix: add StarknetNodes to config schema #7099)
- Introduce unit tests for RegistrySynchronizer
- UpkeepID as a formal type
- Arbitrum Test Support (Arbitrum Test Support #7098)
- Sim backend cltest cleanup (Sim backend cltest cleanup #7101)
- Add fwd tx metadata and metrics for monitoring (Add fwd tx metadata and metrics for monitoring #7102)
- chore: reduce pipeline error log level to warn (chore: reduce pipeline error log level to warn #7085)
- Pretty print upkeepID as prettyID in job spec
- lint error corrections
- final linter fix
- erigon errors (erigon errors #7100)
- core/store/migrations: rename starknet nodes chain id columns (core/store/migrations: rename starknet nodes chain id columns #7107)
- Update log/pool.go & log/pool_test.go for besu (Update log/pool.go & log/pool_test.go for besu #7106)
- Fix logging of msg in ethereum requests
- VRF v2: more prom metrics (VRF v2: more prom metrics #6902)
- Validate the admin address on the FMS chain specific config (Validate the admin address on the FMS chain specific config #7093)
- Corrected PR change request
- Convert NULL tx_index values in log_broadcaster to -1
- Go Generate & lint fixing (Go Generate & lint fixing #7116)
- Add forwardable tx option to gatekeep tx forwarding (Add forwardable tx option to gatekeep tx forwarding #7108)
- connecting starknet components (connecting starknet components #7079)
- Revert chore: reduce pipeline error log level to warn #7085 (Revert #7085 #7135)
- fix: wrong block header serialization on avalanche (fix: wrong block header serialization on avalanche #7122)
- implement ConfirmationDelays() and KeyID() in ocr2vrf coordinator and… (implement ConfirmationDelays() and KeyID() in ocr2vrf coordinator and… #7091)
- add the feature to pause/unpause upkeeps (add the feature to pause/unpause upkeeps #7097)
- chore: minor vrf script updates for goerli (chore: minor vrf script updates for goerli #7134)
- Fixing mockery usage for chains/evm (Fixing mockery usage for chains/evm #7132)
- Add integration tests that demonstrate EIP-150 effect on callWithExactGas (Add integration tests that demonstrate EIP-150 effect on callWithExactGas #7110)
- Fix bug in getting highest confirmed nonce
- handle L2 gas fee for arbitrum and optimism (handle L2 gas fee for arbitrum and optimism #7040)
- Loosens up geth error matching (arbitrum nitro support #7105)
- Ignore uncles and reorgs for Keeper Soak Test (Ignore uncles and reorgs #7144)
- Anti Fragile OCR Soak Test (Anti Fragile OCR Soak Test #7143)
- Deprecated calls of cltest and next portion of mockery usage fixes (Deprecated calls of cltest and next portion of mockery usage fixes #7138)
- fix some nits in KeeperRegistry (sc-47153: fix some remaining nits #7146)
- fetch headers instead of full blocks (fetch headers instead of full blocks #7117)
- Move user functions from proxy to logic (Move user functions from proxy to logic #7065)
- Remove flaky eip-150 integration test (Remove flaky eip-150 integration test #7153)
- Fixing HT flackey tests (Fixing HT flackey tests #7151)
- Fix flakey keeper integration test (Fix flakey keeper integration test #7152)
- core/chains/evm/config: update Arbitrum Rinkeby config for Nitro (core/chains/evm/config: update Arbitrum Rinkeby config for Nitro #7094)
- core/utils: add Wei.String() (core/utils: add Wei.String() #7156)
- tools/bin: remove p/parallel flags from tests (tools/bin: remove p/parallel flags from tests #6856)
- Add forwardable gatekeeping to relay transmitters (Add forwardable gatekeeping to relay transmitters #7157)
- allow admin to mutate check data (allow admin to mutate check data #7147)
- Implement batching for the logPoller (Implement batching for the logPoller #7155)
- tools/bin: restore -p 3 to CI core tests (tools/bin: restore -p 3 to CI core tests #7184)
- Fixed mockery usage (Fixed mockery usage #7183)
- gas limit is uint32 (gas limit is uint32 everywhere #7012)
- Clarify README wrt execution clients
- allow admin change for upkeeps (allow admin change for upkeeps #7161)
- Gas cost functions return uint32
- set timeout for batchSendTransactions call in ethConfirmer (set timeout for batchSendTransactions call in ethConfirmer #7178)
- Forwarder contract return underlying revert msg (Forwarder contract return underlying revert msg #7010)
- Refactor forwarders naming (Refactor forwarders naming #7197)
- fix -short test by skipping sooner (core/chains/evm/log: fix -short test by skipping sooner #7199)
All instances of upkeepID being passed to log output are formatted as strings to make grep searches easier in logs.
To verify the log output is formatted as expected, a unit test was added to `RegistrySynchronizer.syncUpkeepWithCallback`. To accomplish a unit test on this private member function, the test needed to be in the keeper package directly which eliminated the ability to use `cltest` for testing. To avoid the eth client dependency, I introduced a new interface that private functions can receive as a parameter instead of a `RegistryWrapper` directly. This allows function isolation with minimal test setup and simplifies unit testing without the need to rely on the cltest package.
UpkeepIdentifier was created as a wrapper for `utils.Big` to provide support for specific formatting associated with the underlying data. The future intention of this new type is to use it in place of `utils.Big` where the data should be considered an upkeepID. This will allow type checking to apply to instances where an upkeepID is the intended data to be passed through. In addition, errors from the registry wrapper were refactored to provide more context to the errors and leverage the value of error wrapping to identify errors as having originating from contract communication.
* Rinkeby and Goerli
* Sim backend cltest cleanup * Update core/internal/cltest/README.md Co-authored-by: Jordan Krage <jmank88@gmail.com> * Fix test * Fix forwarder test Co-authored-by: Jordan Krage <jmank88@gmail.com>
* add tx metadata and metrics to track fwd tx states * handle case where tx metadata is nil * use strconv for readability
The same pretty print upkeepID function applies to the prettyID field of the job spec. The upkeepID was kept the same; an int represented as a string. To better ensure correctness of the entire job spec, including the upkeepID, UpkeepExecuter.execute was refactored by pulling the job spec build step into its own function. That function is now covered by a unit test.
Updated tests for addLog and added some new ones
- "msg" has special meaning and overrides the main log message, we intended to log it as structured data instead.
Fix logging of msg in ethereum requests
* feat: time until and between tx broadcasts prom metric * feat: time until tx confirmed metric in eth_confirmer * feat: report blocks elapsed until tx confirmed * feat: vrf sim metrics 1. vrf_request_time_between_sims: this will record the duration in between two simulation attempts of the same request. 2. vrf_request_time_until_initial_sim: this will record the duration until a request is first simulated after it's been received.
* Validate the admin address on the FMS chain specific config
- Removed Valuer/Scanner implementation from model.go - Changed new interfaces to private - Changed registry sync error to private
Convert NULL tx_index values in log_broadcaster to -1
* update chainlink-starknet/relayer * import starknet keys from chainlink-starknet, slight interface changes to handle external keys * fix up keystore references * placate linter * connect txm to chains * return stark key in web + cli * bump starknet version, module reorg fixes * add orm test + fix remaining module changes * update keystore with better naming + controllers with explicit descriptions * fix ORM test * fix linter * clean up go.mod * update chainlink-starknet/relayer * connect txm + client, update orm test case * adjust starkpubkey naming, fix debug logs
A change was made to the complete repo to alter data types of gas to uint32. This caused tests in this branch to fail as they were expecting uint64. Also applied some changes to integration tests that were failing when using the -short flag.
* set timeout for batchSendTransactions call in ethConfirmer * bump timeout to 30s and add timeout to batch call in eth_resender * use a different timeout value already consumed by other methods in eth confirmer * increase batch trasnaction timeout to 10 mins * change eth resender batch send timeout to 30 seconds
…mat-bigint-upkeepid Pretty format bigint upkeepID
…ients Clarify README wrt execution clients
HenryNguyen5
requested review from
a team,
jmank88 and
samsondav
as code owners
August 9, 2022 15:47
HenryNguyen5
requested review from
AnieeG,
PiotrTrzpil,
RyanRHall,
alexroan,
connorwstein,
jkongie,
kalverra,
makramkd,
prashantkumar1982,
se3000,
skudasov,
spooktheducks and
tateexon
as code owners
August 9, 2022 15:47
Contributor
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.