Generalised ChainClient - #8843
Merged
Merged
Conversation
Contributor
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
sdrug
commented
Mar 27, 2023
sdrug
commented
Mar 27, 2023
dimriou
reviewed
Mar 27, 2023
aalu1418
reviewed
Mar 29, 2023
… into txm/BCI-1159/use_generics
… into txm/BCI-1159/use_generics
sdrug
marked this pull request as ready for review
April 18, 2023 11:27
sdrug
requested review from
a team,
PiotrTrzpil,
connorwstein and
pinebit
as code owners
April 18, 2023 11:27
| } | ||
|
|
||
| func (ec *EthConfirmer[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) getMinedTransactionCount(ctx context.Context, from ADDR) (nonce uint64, err error) { | ||
| func (ec *EthConfirmer[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) getMinedTransactionCount(ctx context.Context, from ADDR) (nonce evmtypes.Nonce, err error) { |
Contributor
There was a problem hiding this comment.
Huh, this function name is totally misleading.
Could you rename it to: getMinedSequenceForAddress()
jmank88
reviewed
Apr 21, 2023
jmank88
reviewed
Apr 21, 2023
jmank88
reviewed
Apr 21, 2023
Split HASH into TXHASH and BLOCKHASH in generic interface + test fixes Fixing tests Fixing tests SequenceAt mock returns evmtypes.Nonce LINKBalance in client interface Fixing LINKBalance test
dimriou
reviewed
Apr 24, 2023
| func (c *SimulatedBackendClient) FilterEvents(ctx context.Context, q ethereum.FilterQuery) (logs []types.Log, err error) { | ||
| return c.b.FilterLogs(ctx, q) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Why do we keep both FilterEvents and FilterLogs if they are identical?
Contributor
There was a problem hiding this comment.
If i remember correctly, we are trying to use the more generic naming Events rather than Logs
so in the generic interface there is only FilterEvents so we wrap FilterLogs into FilterEvents to conform to the interface
Contributor
Author
There was a problem hiding this comment.
Yep, I tried shifting to the FilterEvents same as we did with nonce -> sequence across the code base, but it's actually too large of a change for this PR, so I limited it to only conforming to the generic interface for now.
aalu1418
reviewed
Apr 24, 2023
| func (c *SimulatedBackendClient) FilterEvents(ctx context.Context, q ethereum.FilterQuery) (logs []types.Log, err error) { | ||
| return c.b.FilterLogs(ctx, q) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
If i remember correctly, we are trying to use the more generic naming Events rather than Logs
so in the generic interface there is only FilterEvents so we wrap FilterLogs into FilterEvents to conform to the interface
prashantkumar1982
approved these changes
Apr 24, 2023
|
SonarQube Quality Gate
|
jmank88
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.