Repository navigation
Remove the scrollbar line from loading and text popups - #50
Open
YoruDev-Ryland wants to merge 1 commit into
Open
YoruDev-Ryland wants to merge 1 commit into
YoruDev-Ryland wants to merge 1 commit into
Conversation
LoadingOverlay and TextPopup.ShowLineAsync wrapped their short, fixed content in OverlayWindow's ScrollView. That ScrollView claims the full host height, so the popup stretched top to bottom with its content bunched at the top, and on some screens (seen on an AYN Odin 3, 1920x1080) the content rounded a pixel past the viewport and Android drew a scrollbar as a dark vertical line down the window's right edge. Both now pass scroll: false, as PadMenu already does for short menus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadingOverlayandTextPopup.ShowLineAsyncopen withKit.OverlayWindow, which wraps content in aScrollViewby default. Their content never scrolls, but on the AYN Odin 3 the scrollbar still shows as a dark vertical line on the right edge.Both now pass
scroll: false, so they size to their content with no scrollbar. Other overlays are unchanged.To check: open any loading popup on an Odin 3, for example while opening a save. Before this change the line is visible. After, it is gone.