Skip to content

feat(raf): add createFrameLoop with delta time, elapsed, and auto-pause - #1032

Open
deny-dz wants to merge 1 commit into
solidjs-community:mainfrom
deny-dz:feat/raf-frameloop-delta
Open

feat(raf): add createFrameLoop with delta time, elapsed, and auto-pause#1032
deny-dz wants to merge 1 commit into
solidjs-community:mainfrom
deny-dz:feat/raf-frameloop-delta

Conversation

@deny-dz

@deny-dz deny-dz commented Aug 22, 2026

Copy link
Copy Markdown

Summary

This PR adds createFrameLoop to @solid-primitives/raf:

  • Delta Time & Elapsed Time Calculation: Supplies exact frame delta time (delta in seconds, clamped to maxDelta) and total running time (elapsed) to the frame callback, essential for 60fps/120fps physics, canvas, WebGL, and sprite animations.
  • Battery & CPU Conservation: Automatically pauses the requestAnimationFrame loop when the browser tab/document is hidden (visibilitychange) and automatically resumes on tab return.
  • Reactive State & Controls: Exposes reactive isRunning accessor alongside start(), stop(), and toggle() handlers.

Changes

  • packages/raf/src/frameloop.ts: Core createFrameLoop implementation.
  • packages/raf/src/index.ts: Re-export createFrameLoop.
  • packages/raf/test/frameloop.test.ts: Vitest test suite.
  • .changeset/raf-frameloop-delta.md: Minor changeset.

@changeset-bot

changeset-bot Bot commented Aug 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 93363dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/raf Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@deny-dz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f47d0866-4b5b-4991-8029-323d80756b3c

📥 Commits

Reviewing files that changed from the base of the PR and between c7b608c and 93363dc.

📒 Files selected for processing (4)
  • .changeset/raf-frameloop-delta.md
  • packages/raf/src/frameloop.ts
  • packages/raf/src/index.ts
  • packages/raf/test/frameloop.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant