Skip to content

feat(virtual): add dynamic item heights and binary search indexing - #1034

Open
deny-dz wants to merge 1 commit into
solidjs-community:mainfrom
deny-dz:feat/virtual-dynamic-heights
Open

feat(virtual): add dynamic item heights and binary search indexing#1034
deny-dz wants to merge 1 commit into
solidjs-community:mainfrom
deny-dz:feat/virtual-dynamic-heights

Conversation

@deny-dz

@deny-dz deny-dz commented Aug 22, 2026

Copy link
Copy Markdown

Summary

This PR resolves the dynamic item height calculations in @solid-primitives/virtual (superseding and fixing stalled PR #803):

  • Dynamic & Variable Row Heights: Supports rowHeight: (item: T, index: number) => number alongside static numeric heights.
  • Exact Container Height Calculation: Fixes bottom truncation by computing total prefix height (prefixSum[N-1] + height[N-1]).
  • Binary Search Seeking ($O(\log N)$): Replaces linear scans with lower-bound binary search over cumulative prefix offset arrays for instant scroll seeking.
  • Scroll-To-Index Utility: Adds scrollToIndex(index, container?, behavior?) with bounds clamping.

Changes

  • packages/virtual/src/index.tsx: Dynamic prefix sum and binary search virtual list implementation.
  • packages/virtual/test/index.test.tsx: Vitest tests for dynamic and static height calculations.
  • .changeset/virtual-dynamic-heights.md: Minor changeset.

@changeset-bot

changeset-bot Bot commented Aug 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 818370a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/virtual Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@deny-dz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 349102ad-7a66-40cf-960a-eecfe35d44af

📥 Commits

Reviewing files that changed from the base of the PR and between c7b608c and 818370a.

📒 Files selected for processing (3)
  • .changeset/virtual-dynamic-heights.md
  • packages/virtual/src/index.tsx
  • packages/virtual/test/index.test.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant