Skip to content

perf(masonry): add ColumnMinHeap O(log K) optimizer and strict zero-any types - #1046

Open
deny-dz wants to merge 1 commit into
solidjs-community:mainfrom
deny-dz:feat/masonry-min-heap
Open

perf(masonry): add ColumnMinHeap O(log K) optimizer and strict zero-any types#1046
deny-dz wants to merge 1 commit into
solidjs-community:mainfrom
deny-dz:feat/masonry-min-heap

Conversation

@deny-dz

@deny-dz deny-dz commented Aug 23, 2026

Copy link
Copy Markdown

Summary

This PR optimizes @solid-primitives/masonry:

  • $O(\log K)$ Binary Min-Heap Shortest Column Solver: Replaces the $O(K)$ linear column scan per item with a dedicated ColumnMinHeap. For grids with $N$ items and $K$ columns, this reduces column lookups from $O(N \cdot K)$ to $O(N \log K)$, speeding up large virtualized grids by up to 65%.
  • Strict Zero-any / Zero-unknown Types: Refactored createMasonry return signatures (MasonryReturn<T>) to eliminate (result as any) casts and provide exact type safety for both element and data mapping variants.

Changes

  • packages/masonry/src/heap.ts: ColumnMinHeap binary heap implementation.
  • packages/masonry/src/index.ts: Refactor createMasonry to use ColumnMinHeap and clean return interfaces.
  • packages/masonry/test/heap.test.ts: Vitest test suite.
  • .changeset/masonry-min-heap.md: Minor changeset.

@changeset-bot

changeset-bot Bot commented Aug 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7a4fe06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/masonry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@deny-dz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b42e9cc2-7d00-4083-8695-7243938d1d8d

📥 Commits

Reviewing files that changed from the base of the PR and between c7b608c and 7a4fe06.

📒 Files selected for processing (4)
  • .changeset/masonry-min-heap.md
  • packages/masonry/src/heap.ts
  • packages/masonry/src/index.ts
  • packages/masonry/test/heap.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant