Add Start v1 coverage to Start v2#1588
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jer3m01
left a comment
There was a problem hiding this comment.
Small SolidBase changes.
Let me know if an extra feature is required, can implement it upstream.
@jer3m01 I do hit a SolidBase limitation here. I need labels that are project (Start) specific. I'd like to not change Solid core's labels from The existing So, if SolidBase can land support for project-specific labels, then I'd be able to use the general config instead of the theme config. |
|
@jer3m01 , i've removed the versionLabels changes, so this PR is just about the docs content, and then the solidbase changes and the version label update can come in follow-up PRs |
Definitely, will add the label option in |
|
Great! This is my failed attempt so far with the genral config: |
I'm not sure what you mean for this. There are project-specific labels? Look here for examples of how to do it - https://github.com/kobaltedev/solidbase/blob/main/dev/vite.config.mts |
|
We need to override the version option’s My undertanding of the solution @jer3m01 mentioned to solve ( #1590 ), is that it can be used like this: |
Start v2 is in Release Candidate.
This adds the same coverage to Start v2 as Start v1 has, and adapt if according to the changes in the changelog.
Before
After