Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Updates the 🤖 Was this summary useful? React with 👍 or 👎 |
| "x-links": [ "https://www.w3.org/TR/xmlschema-2/#time" ], | ||
| "type": "string", | ||
| "pattern": "^(([01][0-9]|2[0-3]):[0-5][0-9]:([0-5][0-9]|60)(\\.[0-9]+)?|24:00:00)(Z|[+-]([01][0-9]|2[0-3]):[0-5][0-9])?$" | ||
| "pattern": "^(([01][0-9]|2[0-3]):[0-5][0-9]:[0-5][0-9](\\.[0-9]+)?|24:00:00(\\.0+)?)(Z|[+-]((0[0-9]|1[0-3]):[0-5][0-9]|14:00))?$" |
There was a problem hiding this comment.
The regex here permits 24:00:00 with a trailing fractional part of only zeros (e.g. 24:00:00.0), but the file’s $comment says hour 24 is only valid as 24:00:00. Consider aligning the comment with the actual constraint to avoid misleading schema consumers.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| }, | ||
| { | ||
| "description": "Valid - leap second", | ||
| "description": "Invalid - leap second is not an XSD dateTime", |
There was a problem hiding this comment.
Since the timezone offset range is now constrained to ±14:00 (and minutes must be 00 when the hour is 14), consider adding tests that +14:00 is valid and e.g. +14:01/+15:00 are invalid. This would better lock in the intended correctness fix.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| }, | ||
| { | ||
| "description": "Valid - leap second", | ||
| "description": "Invalid - leap second is not an XSD time", |
There was a problem hiding this comment.
The updated schema allows 24:00:00 with a fractional part of only zeros (e.g. 24:00:00.0), but the tests only cover 24:00:00 without fractional seconds. Adding a positive case for 24:00:00.0 (and a negative case like 24:00:00.1) would help prevent regressions around this edge case.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com