Repository navigation
Keep the end a conversation opens on, and through a fold above - #87
Open
HugoHeneault wants to merge 5 commits into
Open
HugoHeneault wants to merge 5 commits into
HugoHeneault wants to merge 5 commits into
Conversation
The owner's log showed a conversation followed at its end letting the end go 450 points up within a tenth of a second, with no gesture: a row above it had shrunk, the view moved up by as much, and the follower read that as a reader scrolling up. An upward move no larger than what the document has shrunk by since the mark is not a reader now, and the log line names the conversation.
A place read before a resize was replayed a turn later by viewportWork or placeWork, after the conversation had been opened at its end and the follower had taken over, and put the view back on the top row. Going to the end now leaves the resize pass to restore the end only, and placing the view elsewhere or changing conversation forgets the kept place.
A conversation opened at its end in a pane not yet laid out had its top row kept by viewportWillResize as the reader's place, and the resize pass replayed it once the pane had its height, after the follower had taken the end over: the view went back to the top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #68: two scroll bugs I was still fixing when it was merged. My fault, I should have said that work was still in progress and that we were hitting a few bugs before you merged it.
What changes
Limits
This branch is on my personal fork, so maintainer edits are allowed.