Repository navigation
Test PHP 8.5 and 8.6 with compatible dependencies - #56
Merged
Merged
Conversation
Keep supported Laravel 12/13 combinations and use Pest 5 for Laravel 13. Assert the existing safe fallback when Livewire omits the component name instead of treating Livewire 4 as Livewire 2. Amp-Thread-ID: https://ampcode.com/threads/T-01a1aafd-683e-75eb-9259-0003ad0a1f93
Laravel 12/13 already require a compatible Carbon version. Use Livewire major wildcards rather than caret constraints so Composer arguments survive Windows command parsing. Amp-Thread-ID: https://ampcode.com/threads/T-01a1aafd-683e-75eb-9259-0003ad0a1f93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Hosted CI verified at head
5219afa43fa609f4ac7abc5a5d25b55a1f2490d6: push run and PR run each passed all 36 matrix jobs (72 successful test jobs total). Each run includes 12 PHP 8.5 jobs and 12 PHP 8.6 jobs across Ubuntu/Windows and both dependency preferences. Representative setup/test logs confirm PHP 8.5.12 and PHP 8.6.0-dev actually execute 66 assertions. Older Laravel 12 dependency sets emit deprecations but exit successfully. The separate PHPStan check still has the confirmed 10-error pre-existing baseline, so the overall PR check rollup is not fully green.Hosted Windows compatibility
The first hosted run exposed existing Windows command parsing of caret/pipe constraints. The workflow now lets Laravel choose its Carbon version and passes Livewire major wildcards without shell-sensitive operators. All 18 Linux combinations were rerun successfully after this adjustment. Both final-head hosted test runs now pass, including all Windows jobs.
PHPStan follow-up requested by owner