Java deprecation - #30
Conversation
Avoid treating an empty File path as the current directory on newer JDKs while preserving the existing null and valid-path behavior.
Remove the unused JsEngine project from the nightly Gradle build and test sequence.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46c5f680ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| log4j2.loggerContextFactory=org.apache.logging.log4j.simple.SimpleLoggerContextFactory | |||
There was a problem hiding this comment.
Because this file is under src/main/resources, it is packaged in the SymjaPlus library and Log4j reads it from the consumer's classpath. In any application that brings log4j-core or another Log4j provider, this setting globally forces SimpleLoggerContextFactory, bypassing the application's appenders and configuration and potentially dropping production logs; keep the override out of published main resources and restrict it to tests or launcher configuration.
Useful? React with 👍 / 👎.
|
|
||
| // JGit uses SLF4J 1.7. Keep its logs intentionally disabled without the | ||
| // missing StaticLoggerBinder startup warning. | ||
| runtimeOnly 'org.slf4j:slf4j-nop:1.7.36' |
There was a problem hiding this comment.
JGit 7.1 depends on SLF4J 2.0, while slf4j-nop:1.7.36 is a legacy StaticLoggerBinder binding. When GitPlus runs without another SLF4J 2 provider, the 2.0 API ignores this 1.7 binding, so the startup warning this change is intended to remove remains and logs are not routed to the NOP provider; use a 2.0.x slf4j-nop version aligned with JGit.
Useful? React with 👍 / 👎.
No description provided.