Repository navigation
digicert: support alternate chains for CertCentral issuer - #89
Merged
Merged
Conversation
Add DIGICERT_ALTERNATE_CHAINS, a mapping from authority name to a cross-signed certificate PEM that is appended to the chain of certificates issued by that authority. This mirrors the existing DIGICERT_CIS_ALTERNATE_CHAINS for the CIS issuer and lets us issue certificates that chain to both the DigiCert G1 and G2 roots. The chain is extended in both _download_certificate (used when resolving pending orders) and get_ordered_certificate. The CIS issuer now uses the same helper, which also strips the trailing newline of the intermediate so no blank line ends up between the certificates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report for CI Build 37471649651Coverage remained the same at 59.879%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DIGICERT_ALTERNATE_CHAINSfor the CertCentral issuer (digicert-issuer): a mapping from authority name to a cross-signed certificate PEM that is appended to the chain of certificates issued by that authority. Mirrors the existingDIGICERT_CIS_ALTERNATE_CHAINS._download_certificate(pending-order resolution) andget_ordered_certificate.append_alternate_chain), which also strips the intermediate's trailing newline so the chain has no blank line between certificates.docs/administration.rst.Motivation: the dealer
*.spotify.comcertificate needs a chain that validates against both DigiCert G1 and G2 roots (ADR-047). Today this is done by hand on every renewal; with this change Lemur can produce the same chain automatically for a dedicated authority.Testing
get_ordered_certificatecoverage.test_digicert.pylocally (Python 3.14, no Postgres): the new tests pass, and the pre-existing failures that need the database or app config are the same with and without the change.🤖 Generated with Claude Code