Skip to content

Fix freeze export at 100% SoC #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ajayreddy18 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix freeze export at 100% SoC #5469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/predbat/inverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3446,7 +3446,7 @@ def adjust_export_immediate(self, target_soc, freeze=False):

service_data_stop = {"device_id": self.base.get_arg("device_id", index=self.id, default="")}
extra_data = {"discharge_start_time": self.base.get_arg("discharge_start_time", index=self.id, default="00:00:00"), "discharge_end_time": self.base.get_arg("discharge_end_time", index=self.id, default="00:00:00")}
if target_soc < 100:
if target_soc < 100 or freeze:
# Mirrors adjust_charge_immediate()'s charge_start_service payload just above - the
# actual (possibly low-power-scaled) rate already set via adjust_discharge_rate(), not
# always the inverter's maximum, which produced a full-power discharge_start_service
Expand Down
1 change: 1 addition & 0 deletions apps/predbat/tests/test_inverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5833,6 +5833,7 @@ def run_inverter_tests(my_predbat_dummy):
# deduplicated as a repeat - confirming the fallback isn't re-issued every cycle.
failed |= test_call_adjust_charge_immediate("charge_immediate_freeze_no_service", my_predbat, ha, inv, dummy_items, 50, freeze=True, no_freeze=True, clear=True, stop_discharge=True)
failed |= test_call_adjust_charge_immediate("charge_immediate_freeze_no_service_repeat", my_predbat, ha, inv, dummy_items, 75, freeze=True, no_freeze=True, repeat=True)
failed |= test_call_adjust_export_immediate("export_immediate_freeze_at_100_soc", my_predbat, ha, inv, dummy_items, 100, freeze=True, clear=True)
failed |= test_call_adjust_export_immediate("export_immediate_freeze_no_service", my_predbat, ha, inv, dummy_items, 50, freeze=True, no_freeze=True, clear=True)
failed |= test_call_adjust_export_immediate("export_immediate_freeze_no_service_repeat", my_predbat, ha, inv, dummy_items, 30, freeze=True, no_freeze=True, repeat=True)
if failed:
Expand Down