Repository navigation
docs(debug-journal): fold in the 2026-10-11 queue slice (10 candidates); mark GH#5050 and the GH#5221 event-day instance fixed in PR #5163, GH#5461 fixed in PR #5462, and the Victron template gap fixed in PR #5332 - #5481
Draft
springfall2008 wants to merge 1 commit into
Draft
springfall2008 wants to merge 1 commit into
springfall2008 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated journal update — the
/journal-updateflow folding the 2026-10-11 queue slice. 10 candidates: 10 folded (one of them rewritten as fixed), 0 dropped, 0 left queued. Every claim was re-verified againstorigin/maind7d8c607before folding. Heads-up:./run_pre_commit,pre-commit run --all-filesand the node linters are permission-denied for the triage runner, so the exact hooks could not be run — the applicable ones were replicated by hand (trailing whitespace, end-of-file newline, dictionary case-insensitive sort order, and a token scan of every newly introduced term against the workspace dictionary; one genuine new telemetry key,pac, was added). pre-commit.ci runs the real gate on this PR.Merge sweep — existing entries corrected
rate_minmax_excluding_saving()— saving-tagged minutes mapped back to their pre-event rate, downward-only capping, user overrides applied to the pre-saving snapshot, synthetic minutes with no pre-event rate ignored,rate_max/min/averageuntouched, compare/annual clearing the saving-minute state, pre-event import windows viafind_low_rate_windows()/low_rates_tarifffor the plan while sensors and the non-smart car plan keep tariff-only windows, and the newtest_set_rate_thresholds.pymodule), keeping the pre-fix(fetch): exclude saving-session/Axle boosted minutes from automatic rate thresholds (#5050) #5163 signature for older logs.lowest = 99init inrate_scan_window()is unchanged, so the overwrite-path caveat for future rescans is kept.d7d8c607) addedtemplates/victron.yamland rewrote the docs section (2026-10-10); the "template does not exist (404)" claim is now past tense.load_saving_slot()line cite (octopus.py:2786) had drifted (now~3180); replaced with the symbol name per the journal's own convention.Per-candidate
docs/customisation.md"only applies when iboost_solar and iboost battery are both Off" vs thefetch.pygate((not iboost_solar) and (not iboost_charging)) or iboost_smart, both verified on main), the grid-first combination mechanism, theiboost_rate_threshold-10 floor, the PR iBoost: optional demand-forecast-driven smart planning (iboost_forecast) #4756/Consider solar export value when scheduling EV charging #5384 pointers and the flat-rate test trap.EntityHistory.prune_history()cutoff drops the state-in-force record at the cutoff, so anunavailable/unknownblip as the oldest surviving record floors age to 0 andget_historical(default=20.0)subserves for 24 h; the blip-non-empty-store mechanism (the 2-minute incremental refresh only appends newer epochs); the shared-cache distinction (Predbat's own load path floors age use at 1 day); and the fix trap (the one-line retention fix fails twotest_hahistory.pyassertions encoding the current prune semantics). Still live.octopus_saving_session_min_octopoints_per_kwhOctopus Saving Session value overstated: incentive applied to whole export window, not marginal reduction vs baseline #4893); and the persistence gap (events re-read each cycle) plus the unprobed BottlecapDaveBaselinesattribute pointer.predbat_max_*_limit_actionautomations cite inverter-level names with the plant-ingsuffix — matching neither the plant-ingpair nor the inverter non--ingpair — and the template bindsbattery_rate_maxto the plant-ingname; fix in flight on PR docs(sigenergy): fix rate automation sensor names, re-apply mode on restart, stop zeroing import limit in freeze #5464 (verified unmerged against current main).clipped_today, theinverter_can_charge_during_export+inverter_support_feedin_firstbranch — symbols verified on main), and the reusable log-archaeology traps (grid power = −pac, battery sign conventions, ~15-min poll vs 5-min publish stale cache,etodaycounters ratchet, spot-sample balance reconciliation fails).load_powertotal must also be under the cut-off (noload_power→ the 5-minute figure alone decides; not-low or no-reading → no evidence either way), and the cut-off factor dropped 0.9 → 0.85 (DYNAMIC_LOAD_CAR_LOW_FACTOR, verified on main). Durable mechanism kept: two-consecutive-low-window grace, ramp-window eligibility, confirm/cancel band asymmetry (0.85 vs the full threshold), thecar_charging_energy-sensor strip skip; pre-fix(car): low-load test needs live load power to be low too before cancelling an Intelligent dispatch #5462 signature kept for older logs. The candidate's "byte-identical v9.3.5→main" claim is superseded by the fix._configured_inverter_serialsrecords all serials so_needs_reconfigure()never sees the dropped device as new; the fix trap (a serial-set-membership re-run thrashes every frame — gate on the device becoming usable); Gateway MQTT: defer initial auto-configuration while the hub reports more dongles than inverters #5227's deferral does not cover "listed but unusable"; the greengatewaysuite proves nothing for the partial-outage scenario; fix in flight on PR fix(gateway): keep configured inverters when the hub cannot read them (#5471) #5475 (discovery/auto-config side).or 6000rate fallbacks, the proto-0 export-limit 99999 sentinel read back as 100.0 kW, literal-0reserve_socpublishing, and_check_rate_caps()persisting the fabricated cap on the hub;or 6000dates from the component's first commits (not a regression); fix precedentmerge_non_null(); a greengatewaysuite proves nothing here (no missing-rating case).docs/inverter-setup.md(check-yaml matches only.yaml/.yml; verified against.pre-commit-config.yaml), the two SolaX script blocks broken since Feb 2026 by a wide neighbouring re-indent (PR Docs: Improve LuxPower Freeze Charge Exit Automation: Fix Trigger/Condition Logic to Handle Predbat Restarts #3389), the two break shapes (hard parse error vs silently-parseablevariables: null), and thegit blame -Ltechnique.|) was repaired, and the merge-sweep also surfaced the "manual override partially ignored" class gaining a fixed instance (GH#5423, fixed by PR fix(plan): shrink, not grow, the source window in the export swap's partial combine (#5423) #5447) now noted in the web row.