Skip to content

feat: add assign and strided methods to math/base/special/cexp - #14106

Merged
Planeshifter merged 8 commits into
stdlib-js:developfrom
anandkaranubc:feat/cexp
Oct 2, 2026
Merged

feat: add assign and strided methods to math/base/special/cexp#14106
Planeshifter merged 8 commits into
stdlib-js:developfrom
anandkaranubc:feat/cexp

Conversation

@anandkaranubc

@anandkaranubc anandkaranubc commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Resolves stdlib-js/metr-issue-tracker#1132

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used Claude Code code-generation tools to help assist with the feature.

@stdlib-js/reviewers

@anandkaranubc
feat: add assign and strided methods to math/base/special/cexp
300d630 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: code review
3554b27 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: code review
6a62149 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
anandkaranubc requested a review from a team August 9, 2026 19:44
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Aug 9, 2026
@stdlib-bot

stdlib-bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cexp $\\color{green}322/322$
$\\color{green}+0.00\\%$ 		$\\color{green}20/20$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}322/322$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@anandkaranubc anandkaranubc added the METR Pull request associated with the METR project. label Aug 9, 2026
@anandkaranubc
chore: code review
b2579a0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: code review
ea4e649 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc

anandkaranubc commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Also cleaned up the whole package to follow the latest project conventions 😌

@stdlib-bot stdlib-bot added the Merge Conflicts Pull request which has merge conflicts. label Aug 14, 2026
anandkaranubc and others added 2 commits August 14, 2026 21:15
@anandkaranubc @claude
chore: merge develop into feat/cexp
501029a 
Resolve merge conflicts in test files:

- test.js: keep HEAD's method-existence-only pattern (functional tests
  live in test.main.js)
- test.native.js: take develop's 1 ULP for generalComplex real
  (systematic ULP migration)
- test.main.js: tighten ULP from 1 to exact, use direct strictEqual
  instead of isAlmostSameValue
- test.assign.js: tighten ULP from 1 to exact, use isSameFloat64Array
- test.strided.js: tighten ULP from 1 to exact, use isSameFloat64Array

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@anandkaranubc
Merge branch 'develop' into feat/cexp
184d2fb
@anandkaranubc anandkaranubc removed the Merge Conflicts Pull request which has merge conflicts. label Aug 15, 2026
This was referenced Aug 15, 2026
Merged
Open
@anandkaranubc
anandkaranubc requested a review from kgryte September 7, 2026 21:09
@Planeshifter Planeshifter mentioned this pull request Oct 2, 2026
Closed
Planeshifter
Planeshifter approved these changes Oct 2, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Oct 2, 2026
@Planeshifter
Planeshifter merged commit 019291d into stdlib-js:develop Oct 2, 2026
14 checks passed
@anandkaranubc anandkaranubc mentioned this pull request Oct 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes
@kgryte kgryte Awaiting requested review from kgryte

Assignees

No one assigned

Labels

Math Issue or pull request specific to math functionality. METR Pull request associated with the METR project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add assign and strided methods to math/base/special/cexp

3 participants

@anandkaranubc @stdlib-bot @Planeshifter