test: migrate simulate/iter/cosine-wave to ULP-based assertions - #15592
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012FeJjoxKgvZczJEKgkvTwY --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
simulate/iter/cosine-wavefrom relative tolerance assertions to ULP-based assertions, per the guidance in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomparison intest/test.jswitht.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' );, adding the@stdlib/assert/is-almost-same-valuerequire and removing the now-unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires along with thedeltaandtoldeclarations.All seven converted assertion sites use a ULP bound of
0. The bound was tightened agentically: starting from64, the suite was re-run while lowering the value, and0is the measured minimum — the accumulated values are bit-identical to the expected values across the full fixture set, so no nonzero budget is required. The suite was run twice at the final bound to confirm determinism (231 assertions passing on both runs, no FMA/arch variation).0also matches the bound the sibling packagessimulate/iter/sawtooth-waveandsimulate/iter/triangle-wavesettled on.The package has no
test/test.native.js, andtest/test.validate.jscontains no tolerance math, sotest/test.jsis the only file changed.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The conversion mirrors the idiom established in 4a73a48 (
simulate/iter/triangle-wave) and thesimulate/iter/sawtooth-waveconversion: an inline ULP literal rather than a named constant, and the'returns expected value'message on every case.Verification performed locally:
make test TESTS_FILTER=".*/simulate/iter/cosine-wave/.*"— 231 assertions passing (run twice at the final bound).make lint-javascript-tests TESTS_FILTER=".*/simulate/iter/cosine-wave/.*"— clean.make lint-editorconfig-filescould not run in this environment, as it downloads theeditorconfig-checkerrelease binary and outbound access to that host was blocked. Compliance was instead verified manually for the changed file: LF line endings, UTF-8, tab indentation, no trailing whitespace, and a final newline.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running unattended as a scheduled task. It studied #11352 and the prior
simulate/iter/sawtooth-waveandsimulate/iter/triangle-waveconversions to mirror the established idiom, performed the mechanical substitution, and searched for the minimum passing ULP bound by re-running the test suite.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_012FeJjoxKgvZczJEKgkvTwY
Generated by Claude Code