test: migrate stats/base/snanstdevtk to ULP-based assertions - #15599
Merged
Merged
Conversation
Replaces the computed EPS/tolerance idiom (`abs( v - expected ) <= tol`) with `isAlmostSameValuef` ULP-difference comparisons in the package's four strided-array test files. Mirrors the approach already used in the sibling `stats/base/snanstdev` package. Ref: #11352 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLQVoEVhUdPCfyaqueCuD5 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/snanstdevtktest suite from the computed EPS/tolerance idiom (delta = abs( v - expected ); tol = 1.0 * EPS * abs( expected ); t.strictEqual( delta <= tol, ... )) to ULP-difference assertions using@stdlib/number/float32/base/assert/is-almost-same-value(isAlmostSameValuef), per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.snanstdevtk.js,test/test.snanstdevtk.native.js,test/test.ndarray.js, andtest/test.ndarray.native.js(the four files containing the tolerance idiom).1is the minimum integer ULP distance for which all assertions in all four files pass;0fails 2 of the 36 assertions in each file. This matches the ULP bound already settled on for the sibling packagestats/base/snanstdev(see PR test: migratestats/base/snanstdevto ULP-based assertions #15216), whose test files follow an identical pattern.1with identical (all-passing) results.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only the four test files were changed; no new dependency was introduced (
@stdlib/number/float32/base/assert/is-almost-same-valuealready exists in the monorepo and is already used by other converted packages, e.g.stats/base/snanstdev).npx eslinton the changed files reports no issues, andmake test TESTS_FILTER=".*/stats/base/snanstdevtk/.*"passes (36/36 in each JS test file; native variants report 0 tests, as expected when the native addon is not built in this environment).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running as an unattended scheduled task: it discovered the candidate package, studied prior art from already-merged ULP-migration PRs (including #15216 for the sibling
snanstdevpackage), performed the conversion, and empirically determined the tightest ULP bound.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01WLQVoEVhUdPCfyaqueCuD5
Generated by Claude Code