Repository navigation
fix(doctor): --fix demande le mot de passe sudo même juste après un sudo en cache (0.9.6) - #385
Merged
Merged
Conversation
…udo en cache (0.9.6) Signalé sur Pop!_OS 24.04 le 2026-11-16 : `sudo -n true` réussissait grâce au mot de passe que sudo garde quelques minutes, dsoxlab omettait --ask-become-pass, et le sudo d Ansible échouait (« il est nécessaire de saisir un mot de passe »). La sonde est désormais `sudo -n -k true`. Les étapes facultatives se numérotent à la suite (« 0. Installer Docker »). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported on Pop!_OS 24.04 right after 0.9.5:
dsoxlab doctor --fix --clientsstarted the workstation playbook without--ask-become-pass, and Ansible's sudo failed with "sudo: il est nécessaire de saisir un mot de passe". The probe wassudo -n true, which also succeeds thanks to the password sudo caches for a few minutes in the terminal; Ansible's sudo does not see that cache. The probe is nowsudo -n -k true:-kignores the cached credentials for that command (without removing them), so only a real passwordless sudo skips the question.Also: optional steps (
--clients) are numbered after the required ones instead of "0.".Not reproducible on the reference machine (its sudo is a real
NOPASSWD: ALL); the fix follows the documented-ksemantics and is covered by a test on the probe and on both outcomes. To be confirmed on the Pop!_OS machine after release.Type of change
Checklist
Always
uv run ruff check src/dsoxlab testspassesuv run mypy src/dsoxlabpasses (strict)uv run pytestpasses (2471)uv run pytest tests_e2e: N/A locally for this two-line fix; run by CI--fix, independent of the catalogueWhen behavior changes — otherwise N/A
CHANGELOG.mdandCHANGELOG.fr.mdupdated (0.9.6)pyproject.toml,uv.lockrefreshedWhen a command or option is added, removed or changed — otherwise N/A
N/A: no option changes.
When
.github/workflows/is touched — otherwise N/AN/A.
When the declarative contract (
meta.yml/lab.yaml) changes — otherwise N/AN/A.
Related issues
Follow-up to #384.
🤖 Generated with Claude Code