Skip to content

ci(release): l'appliance se construit après la release, appelée par release.yml - #388

Merged
stephrobert merged 1 commit into
mainfrom
ci/appliance-apres-release
Nov 16, 2026
Merged

stephrobert merged 1 commit into
mainfrom
ci/appliance-apres-release

Conversation

@stephrobert

Copy link
Copy Markdown
Owner

Summary

On v0.9.7, Appliance and Release both started on the tag push and ran in parallel, although appliance.yml's own header promised "AFTER the Release exists". Nothing enforced the order.

  • appliance.yml becomes a reusable workflow (on: workflow_call with a required tag input); its push: tags trigger is removed. workflow_dispatch stays, to catch up a missed build by hand.
  • release.yml gains a last job, appliance, with needs: [github_release]: the image is built only once the version is on PyPI and the GitHub Release exists, and its failure can neither delay nor fail the publication.
  • The existing conditions keep working: inside a called workflow, github.event_name is the caller's (push) and inputs.tag is set, so the retention and attach steps run as before; IMAGE_REF still resolves to the tag.

Not exercised yet: the next tag will be the first run of the new chain. If it fails, workflow_dispatch with the tag rebuilds the images.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Chore / tooling
  • Security / supply chain

Checklist

Always

  • ruff / mypy / pytest / tests_e2e: N/A, no Python changed; CI runs them
  • The engine stays domain-agnostic
  • No hardcoded personal path or host
  • Two lab repositories: N/A, CI-only change

When behavior changes — otherwise N/A

N/A: no user-facing behavior; no CHANGELOG entry, no version bump.

When a command or option is added, removed or changed — otherwise N/A

N/A.

When .github/workflows/ is touched — otherwise N/A

  • actionlint clean
  • zizmor --offline .github/workflows/: no finding at the CI's pinned version (1.26.1). Local zizmor 1.30 adds one low self-repository note suggesting $/... over ./... for the local reusable workflow; kept ./..., the documented syntax that actionlint accepts.
  • poutine analyze_local . --fail-on-violation clean
  • No action added or re-pinned
  • step-security/harden-runner remains the first step of every job (the new job only calls the reusable workflow, whose job keeps it first)
  • No job renamed in the CI workflow; the appliance check now appears as Release / Appliance / Build the appliance image (it is not a required status check: it runs on tags only)
  • No new third-party action

When the declarative contract (meta.yml / lab.yaml) changes — otherwise N/A

N/A.

Related issues

None.

🤖 Generated with Claude Code

…elease.yml

Les deux workflows partaient en parallèle sur le tag (vu sur v0.9.7), alors
que l en-tête de appliance.yml promettait « après la Release ». L appliance
devient un workflow appelé (workflow_call) par le dernier job de
release.yml, qui attend la création de la Release GitHub, donc la
publication PyPI. workflow_dispatch reste pour rattraper un build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stephrobert
stephrobert merged commit 68f48dd into main Nov 16, 2026
20 checks passed
@stephrobert
stephrobert deleted the ci/appliance-apres-release branch November 16, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant