Repository navigation
ci(release): l'appliance se construit après la release, appelée par release.yml - #388
Merged
Merged
Conversation
…elease.yml Les deux workflows partaient en parallèle sur le tag (vu sur v0.9.7), alors que l en-tête de appliance.yml promettait « après la Release ». L appliance devient un workflow appelé (workflow_call) par le dernier job de release.yml, qui attend la création de la Release GitHub, donc la publication PyPI. workflow_dispatch reste pour rattraper un build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On v0.9.7,
ApplianceandReleaseboth started on the tag push and ran in parallel, althoughappliance.yml's own header promised "AFTER the Release exists". Nothing enforced the order.appliance.ymlbecomes a reusable workflow (on: workflow_callwith a requiredtaginput); itspush: tagstrigger is removed.workflow_dispatchstays, to catch up a missed build by hand.release.ymlgains a last job,appliance, withneeds: [github_release]: the image is built only once the version is on PyPI and the GitHub Release exists, and its failure can neither delay nor fail the publication.github.event_nameis the caller's (push) andinputs.tagis set, so the retention and attach steps run as before;IMAGE_REFstill resolves to the tag.Not exercised yet: the next tag will be the first run of the new chain. If it fails,
workflow_dispatchwith the tag rebuilds the images.Type of change
Checklist
Always
When behavior changes — otherwise N/A
N/A: no user-facing behavior; no CHANGELOG entry, no version bump.
When a command or option is added, removed or changed — otherwise N/A
N/A.
When
.github/workflows/is touched — otherwise N/Aactionlintcleanzizmor --offline .github/workflows/: no finding at the CI's pinned version (1.26.1). Local zizmor 1.30 adds onelowself-repositorynote suggesting$/...over./...for the local reusable workflow; kept./..., the documented syntax that actionlint accepts.poutine analyze_local . --fail-on-violationcleanstep-security/harden-runnerremains the first step of every job (the new job only calls the reusable workflow, whose job keeps it first)Release / Appliance / Build the appliance image(it is not a required status check: it runs on tags only)When the declarative contract (
meta.yml/lab.yaml) changes — otherwise N/AN/A.
Related issues
None.
🤖 Generated with Claude Code