Skip to content

misc: Use ansible_facts instead of deprecated top-level fact variables - #179

Merged
vojtechtrefny merged 1 commit into
storaged-project:mainfrom
vojtechtrefny:main_fix-ansible-deprecated
Aug 21, 2026
Merged

misc: Use ansible_facts instead of deprecated top-level fact variables#179
vojtechtrefny merged 1 commit into
storaged-project:mainfrom
vojtechtrefny:main_fix-ansible-deprecated

Conversation

@vojtechtrefny

@vojtechtrefny vojtechtrefny commented Aug 20, 2026

Copy link
Copy Markdown
Member

Ansible deprecated the injected top-level ansible_* fact variables (e.g. ansible_distribution) in favour of accessing them through the ansible_facts dictionary.

Summary by CodeRabbit

  • Chores
    • Updated distribution detection for dependency installation tasks.
    • Preserved existing Fedora, CentOS, Debian, and Ubuntu installation commands, packages, and configuration.

Ansible deprecated the injected top-level ansible_* fact variables
(e.g. ansible_distribution) in favour of accessing them through the
ansible_facts dictionary.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 01c357dc-22eb-4447-978f-0e9c89651ae8

📥 Commits

Reviewing files that changed from the base of the PR and between 7f5e75a and a174177.

📒 Files selected for processing (1)
  • misc/libbytesize-tasks.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Ansible task file now uses ansible_facts['distribution'] for Fedora, CentOS, Debian, and Ubuntu conditions. Existing dependency installation commands, packages, and pip settings remain unchanged.

Changes

Distribution condition updates

Layer / File(s) Summary
Update distribution conditionals
misc/libbytesize-tasks.yml
Distribution-specific dependency and test-tool tasks now use ansible_facts['distribution']. Installation commands, packages, repository setup, and pip options remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to a1741

This localized change updates Ansible fact access without any identified merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes replacing deprecated top-level Ansible fact variables with the ansible_facts dictionary, which matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vojtechtrefny
vojtechtrefny merged commit 76eccb3 into storaged-project:main Aug 21, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants