fix: paginate workflow run cancellation#219
Open
jay-babu wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the workflow-run retrieval logic to page through all workflow runs (instead of a single page) and conditionally filter by status, so downstream cancel-selection logic has a complete dataset.
Changes:
- Replace
listWorkflowRunssingle-call response handling withoctokit.paginate(...)to fetch all workflow runs. - Conditionally add a
statusfilter whenonly_statusis set (andall_but_latestis not). - Update logging to reflect the number of runs fetched.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/index.ts | Switches workflow runs fetching to pagination and optionally applies status filtering. |
| dist/index.js | Compiled output reflecting the updated pagination + status-filter logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+72
to
+85
| const listWorkflowRunsParams: any = { | ||
| per_page: 100, | ||
| owner, | ||
| repo, | ||
| // @ts-ignore | ||
| workflow_id, | ||
| branch, | ||
| }); | ||
| console.log(`Found ${total_count} runs total.`); | ||
| }; | ||
| if (only_status && !all_but_latest) { | ||
| listWorkflowRunsParams.status = only_status; | ||
| } | ||
| const workflow_runs: any[] = await octokit.paginate( | ||
| octokit.rest.actions.listWorkflowRuns, | ||
| listWorkflowRunsParams, | ||
| ); |
Comment on lines
+82
to
+85
| const workflow_runs: any[] = await octokit.paginate( | ||
| octokit.rest.actions.listWorkflowRuns, | ||
| listWorkflowRunsParams, | ||
| ); |
| }); | ||
| console.log(`Found ${total_count} runs total.`); | ||
| }; | ||
| if (only_status && !all_but_latest) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listWorkflowRunsso the action considers every matching workflow run, not just the first 100 returned by the APIonly_statusis set andall_but_latestis not set, pass that status to the API so runs in statuses likewaitingare not hidden behind recent completed runsall_but_latestsemantics by fetching all statuses when that option is enabledFixes #218.
Test Plan
yarn format-checkyarn buildnpx tsc --noEmit