Add interactive pagination when listing machines. - #5113
Draft
NullHypothesis wants to merge 1 commit into
Draft
Conversation
This PR makes flyctl use the pagination-enabled `listMachines` v2 endpoint. When listing a large number of machines, flyctl lets you interactively page through the list of machines. The newly added flag `--limit` controls the page size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes flyctl use the pagination-enabled
listMachinesv2 endpoint. When listing a large number of machines, flyctl lets you interactively page through the list of machines. The newly added flag--limitcontrols the page size.Documentation
--limitflag. docs#2467)