BridgeJS: Support generic functions on imported JS APIs - #799
Open
krodak wants to merge 2 commits into
Open
Conversation
Comment on lines
+418
to
+432
| Bool.bridgeJSTypeID, | ||
| Int.bridgeJSTypeID, | ||
| Int8.bridgeJSTypeID, | ||
| UInt8.bridgeJSTypeID, | ||
| Int16.bridgeJSTypeID, | ||
| UInt16.bridgeJSTypeID, | ||
| Int32.bridgeJSTypeID, | ||
| UInt32.bridgeJSTypeID, | ||
| UInt.bridgeJSTypeID, | ||
| Int64.bridgeJSTypeID, | ||
| UInt64.bridgeJSTypeID, | ||
| Float.bridgeJSTypeID, | ||
| Double.bridgeJSTypeID, | ||
| String.bridgeJSTypeID, | ||
| JSValue.bridgeJSTypeID, |
Member
There was a problem hiding this comment.
Can we put those core type table entries in JavaScriptKit instead of defining in every module?
| prefix: "const \(codecVar) = ", | ||
| suffix: ";" | ||
| ) | ||
| return codecVar |
Member
There was a problem hiding this comment.
Shouldn't we define a codec helper instead of inlining them? I think we can define StackABI codec helpers for any type that can appear in those combinators' element positions. And it should be shared with the one in type table entries.
| return jsValue; | ||
| } | ||
|
|
||
| const __bjs_createGenericPointHelpers = () => ({ |
Member
There was a problem hiding this comment.
We need to include the module name to allow name collisions across modules.
Member
Author
There was a problem hiding this comment.
Oh sorry, I reverted that change, will bring it back in a few 🙏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import half of generic function support (#398), split out of #787 per review. An imported
@JSFunctioncan take a type parameter, so one declaration covers every bridged type:Tcan be any primitive,String,JSValue, or a@JSstruct/enum/final class, bare or asT?,[T],[String: T]. Also works on@JSClassinits, methods and statics, and for return-only generics. Exported generics are rejected with a diagnostic and land separately on top of this ABI.How it works
i32type ID per type parameter, so type-agnostic JS glue can pick the right lift/lower.BridgeJSTypeHandle, its address is the ID. Same-named types in different modules can't collide, and no existentials means it works under Embedded.bjs_<Module>_register_type_handles, which hands its IDs to JS; JS pairs them with its codec table by index. Runs eagerly via a newafterInitializeinstantiator hook, or lazily on first generic call (worker threads).@JStype, not just in modules that declare generics, module B can pass module A's type to a generic function (per BridgeJS: Support generic functions at the Swift and JavaScript boundary #787 review).__bjs_arrayCodecetc.); the non-generic array/dict/optional paths now reuse them instead of inlining a copy per thunk (per BridgeJS: Support generic functions at the Swift and JavaScript boundary #787 review on the stack ABI clones).Builds without generics don't get the JS generic runtime, just a no-op registration hook per module with
@JStypes.Test plan
ImportGenericAPITests: runtime round-trip of every bridgeable type through real JS, includingJSON.parseExamples/Embeddedbuilds a generic round-trip in CI