Conversation
|
Ok, kicking of with a summary and a couple of notes and TODO items while my memory is reasonably fresh. See https://tmt--4364.org.readthedocs.build/en/4364/environment.html for the preview. Ignore the location of the document, I just needed to hook it somewhere. |
|
Synced priority with the issue and proposed for the next sprint as agreed on the hacking session. |
c1f008e to
cf4c675
Compare
cda563a to
e6331d1
Compare
21dc872 to
f448eac
Compare
f448eac to
8324b82
Compare
8324b82 to
15df292
Compare
ca5868d to
eb749a4
Compare
eb749a4 to
f594fcf
Compare
f594fcf to
3ff09df
Compare
3ff09df to
cddc08c
Compare
LecrisUT
left a comment
There was a problem hiding this comment.
Overall LGTM, only confusion is with the "User"
| 1. User-provided test environment | ||
| ::::::::::::::::::::::::::::::::: |
There was a problem hiding this comment.
Is there a different wording we could use here. "User-provided" is a bit loaded and overlaps with the "command line" part. For me the user here is more like the executioner, not the author of the fmf file, so probably that's why it gets more loaded for me.
There was a problem hiding this comment.
Not having any idea of my own, I'm open to suggestions.
There was a problem hiding this comment.
Hmm, some possibilities: "static", "fmf file defined", "author defined" (would need glossary), just "test environment"?
Also for this one in particular it could use a quick note on adjust-test? Or have somewhere to explicitly mention where the fmf file evaluation (and discover) fit in here.
There was a problem hiding this comment.
I use "user" as a term in contrast to "variables added and owned by tmt", with no distiction between "user who wrote fmf files" and "user who runs tmt run". I believe we don't have dedicated labels for these two roles.
cddc08c to
5b4634a
Compare
5b4634a to
3cb51ec
Compare
Related to #4241
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
3cb51ec to
5685d99
Compare
Related to #4241
See #4241 for TODO items and tracking.
See https://tmt--4364.org.readthedocs.build/en/4364/environment.html for the preview.
Pull Request Checklist