Conversation
happz
added
code | no functional change
lukaszachy
requested changes
Aug 26, 2026
lukaszachy
left a comment
lukaszachy
left a comment
Contributor
There was a problem hiding this comment.
Wrong import which makes few tests fail. Otherwise LGTM
| import socketserver | ||
| import threading | ||
|
|
||
| import tmt.utils.time |
Contributor
There was a problem hiding this comment.
ModuleNotFoundError: No module named 'tmt.utils.time'
lukaszachy
reviewed
Aug 26, 2026
Instead of `time.sleep()` which does not play well with threads and tmt interrupt process. Related to #5009.
happz
force-pushed
the
time-sleep-alternative
branch
from
August 31, 2026 07:33
6a6384d to
69e5016
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
time.sleep()which does not play well with threads and tmt interrupt process.Related to #5009.
Pull Request Checklist