Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
added this pull request to stack #5152
September 14, 2026 16:25
LecrisUT
added
the
ci | full test
1 task
happz
reviewed
Sep 15, 2026
|
|
||
|
|
||
| class CliRunner(click.testing.CliRunner): | ||
| opts: Optional[TmtCliOptions] = None |
Contributor
There was a problem hiding this comment.
Is options already claimed by Click? If so, I'd still prefer some form of "options", e.g. _tmt_options, _our_options, etc., to align with TmtCliOptions, TmtCliRunOptions, to_options, _tmt_cli_options, and so on. opts break the pattern for no obvious reason.
Member
Author
There was a problem hiding this comment.
No reason, just how my fingers flowed at that time :) 96ec4c8
Signed-off-by: Cristian Le <git@lecris.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by the design in #5151, this adds a way to inject and alter the cli options in a more composable way