Conversation
LecrisUT
reviewed
Sep 16, 2026
Member
Author
|
/packit test |
psss
force-pushed
the
psss-drop-python-3.9
branch
from
September 17, 2026 07:55
3d1517c to
b6f32a7
Compare
LecrisUT
reviewed
Sep 17, 2026
LecrisUT
reviewed
Sep 17, 2026
psss
added this pull request to stack #5174
September 17, 2026 13:42
psss
force-pushed
the
psss-drop-python-3.9
branch
from
September 17, 2026 14:51
4cce48c to
6e64492
Compare
Contributor
|
@psss is "test" in "... for the test runner" correct? I'd expct to read "tmt runner" or something similar. |
psss
force-pushed
the
psss-drop-python-3.9
branch
from
September 18, 2026 10:45
6e64492 to
e5da12c
Compare
Member
Author
psss
removed this pull request from stack #5174
September 18, 2026 11:01
psss
added this pull request to stack #5178
September 18, 2026 11:03
Contributor
It seems to me the changes are in the right direction, but separated into PRs in an unexpected way. |
therazix
force-pushed
the
psss-drop-python-3.9
branch
from
September 18, 2026 19:55
e5da12c to
45e901a
Compare
happz
force-pushed
the
psss-drop-python-3.9
branch
from
September 19, 2026 14:36
45e901a to
b50d1ff
Compare
LecrisUT
approved these changes
Sep 21, 2026
LecrisUT
left a comment
Member
There was a problem hiding this comment.
Other than changing the title, looks ok. All of the ubuntu parts are still as ❓ but we can handle that later ™️
This reverts commit b6f32a7.
psss
force-pushed
the
psss-drop-python-3.9
branch
from
September 21, 2026 17:45
b50d1ff to
4f5a515
Compare
Member
Author
Yeah, makes sense. I've bumped the required Python version in 4f5a515. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Resolve #5062.