Use with_child_unrestricted in pydantic_converter_v1 sample - #342
Open
PardhuTI wants to merge 1 commit into
Open
Use with_child_unrestricted in pydantic_converter_v1 sample#342PardhuTI wants to merge 1 commit into
PardhuTI wants to merge 1 commit into
Conversation
The upstream SDK fix this workaround waited on (temporalio/sdk-python#254) has shipped, so replace the manual removal of the datetime restriction with with_child_unrestricted. Closes temporalio#126
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pydantic_converter_v1/worker.pycarried a TODO to switch its sandbox setup towith_child_unrestrictedonce temporalio/sdk-python#254 was fixed and released.That fix has shipped, so this replaces the manual "copy the children map and
delete the datetime key" workaround with the intended one-liner.
with_child_unrestricted("datetime")is equivalent here, and slightly morecomplete: for a single-element path it clears the key from
access,use, andchildren, whereas the old code only removed it fromchildren.Closes #126
Testing
pytest tests/pydantic_converter_v1/passes (workflow round-trips Pydanticmodels with datetime fields);
ruff format --check,ruff check, andmypyare clean.