Liquid support

[njt1982]

Hi,

How would we go about adding support for Liquid? Eg:

{% comment %}
  Interesting comment here
{% endcomment %}

They can also be inline

{% comment %}Interesting comment here{% endcomment %}

[thedadams]

The block-type comments are already supported.

Getting the inline comments to work correctly would take a bit of work.

[njt1982]

Hmm - they dont highlight for me?

Also, the # comments dont highlight either?

[njt1982]

Looks like liquid has the right injection code in it...

https://github.com/TheBeyondGroup/zed-shopify-liquid/blob/60994c47493b52ac13cc228128060923d577f879/languages/liquid/injections.scm#L23-L24

[njt1982]

It's more than possible this is a "meat based problem" as I'm still new to Zed ;)

[thedadams]

This extension only highlights comments that start with specific "tags" like TODO or FIXME etc. See the README for the full list.

In the screenshots you posted, I don't see any comments that start with those tags. Also, I am not familiar enough with liquid to know the difference between # comments and {% comment %} comments. It could be that they are different scopes in the grammar and the extension would need to inject those as well.