Topology2: add sof-sdca-mic-4ch-id4 tplgs support

[bardliao]

Add 4 channel sdca mic function topologies support.

[Copilot]

Pull request overview

This PR extends the Topology2 SDCA generic build targets to add 4-channel and 8-channel SoundWire DMIC (“SmartMic”) function topologies, and updates the Intel sdw-dmic-generic.conf platform fragment to make capture channel count/config/map configurable via new defines.

Changes:

• Add new sof-sdca-mic-4ch-id4 and sof-sdca-mic-8ch-id4 topology build targets (via NUM_DMICS overrides).
• Teach sdw-dmic-generic.conf to derive DMIC PCM channel count (and ch cfg/map) from NUM_DMICS when SDW_DMIC_PCM_CHANNELS=0, and propagate this into DAI/widget/PCM caps formats.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tools/topology/topology2/production/tplg-targets-sdca-generic.cmake	Adds new SDCA mic tplg targets for 4ch and 8ch variants using NUM_DMICS overrides.
tools/topology/topology2/platform/intel/sdw-dmic-generic.conf	Makes SDW DMIC capture channel count/config/map variable-driven and wires it through DAI/widgets/PCM caps.

[lgirdwood]

LGTM

[bardliao]

Based on @shumingfan's test result, it seems it will duplicate ch0 to all other channels. I am trying to figure it out.

[bardliao]

@singalsu Below error will happen if I set EFX_MIC_TDFB_PARAMS=line4_generic_pm10deg. Could you take a look when you are back?

[    5.067519] sof-audio-pci-intel-ptl 0000:00:1f.3: bytes control Microphone Capture TDFB bytes initial data size 1572 exceeds max 1024.
[    5.067528] sof-audio-pci-intel-ptl 0000:00:1f.3: failed updating IPC struct for control Microphone Capture TDFB bytes
[    5.067533] sof-audio-pci-intel-ptl 0000:00:1f.3: error: failed to load DSP topology -22

[singalsu]

@singalsu Below error will happen if I set EFX_MIC_TDFB_PARAMS=line4_generic_pm10deg. Could you take a look when you are back?

[    5.067519] sof-audio-pci-intel-ptl 0000:00:1f.3: bytes control Microphone Capture TDFB bytes initial data size 1572 exceeds max 1024.
[    5.067528] sof-audio-pci-intel-ptl 0000:00:1f.3: failed updating IPC struct for control Microphone Capture TDFB bytes
[    5.067533] sof-audio-pci-intel-ptl 0000:00:1f.3: error: failed to load DSP topology -22

This was merged a while ago. Is this outside of scope of tools/topology/topology2/platform/intel/sdw-dmic-generic.conf ?

https://github.com/thesofproject/sof/pull/10970/files

Generally I'd recommend to use line4_pass.conf that effectively disables the beamformer until we better understand the microphone arrays placement for mic count > 2 if there is a safe generic assumption. Also the channels map for user space is not clear, how the four channels should appear, or should we convert in beamformer it to normal L/R stereo 2ch. It would be safest but then all the microphones would not be exposed to user.

Even with line4_pass, the control size issue should be fixed in the topology to not have blockers to enable beamformer later.

[bardliao]

@singalsu Below error will happen if I set EFX_MIC_TDFB_PARAMS=line4_generic_pm10deg. Could you take a look when you are back?

[    5.067519] sof-audio-pci-intel-ptl 0000:00:1f.3: bytes control Microphone Capture TDFB bytes initial data size 1572 exceeds max 1024.
[    5.067528] sof-audio-pci-intel-ptl 0000:00:1f.3: failed updating IPC struct for control Microphone Capture TDFB bytes
[    5.067533] sof-audio-pci-intel-ptl 0000:00:1f.3: error: failed to load DSP topology -22

This was merged a while ago. Is this outside of scope of tools/topology/topology2/platform/intel/sdw-dmic-generic.conf ?

https://github.com/thesofproject/sof/pull/10970/files

No, it is inside sdw-dmic-generic.conf.

diff --git a/tools/topology/topology2/include/controls/bytes.conf b/tools/topology/topology2/include/controls/bytes.conf
index 1483e36f10a3..26659d65890a 100644
--- a/tools/topology/topology2/include/controls/bytes.conf
+++ b/tools/topology/topology2/include/controls/bytes.conf
@@ -82,7 +82,7 @@ Class.Control."bytes" {
        }

        # Default attribute values for bytes control
-       max     1024
+       max     2048
        !access [
                tlv_write
                tlv_read

seems fix the issue. But then another issue comes up

Generally I'd recommend to use line4_pass.conf that effectively disables the beamformer until we better understand the microphone arrays placement for mic count > 2 if there is a safe generic assumption. Also the channels map for user space is not clear, how the four channels should appear, or should we convert in beamformer it to normal L/R stereo 2ch. It would be safest but then all the microphones would not be exposed to user.

Perfect, I will keep it as line4_pass

Even with line4_pass, the control size issue should be fixed in the topology to not have blockers to enable beamformer later.