Repository navigation
feat(react): support React 19 with lifecycle compatibility tests - #84
Open
siddontang wants to merge 1 commit into
Open
siddontang wants to merge 1 commit into
siddontang wants to merge 1 commit into
Conversation
Signed-off-by: siddon <siddontang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The React wrapper currently rejects React 19 through its
^18.3.1peer range, although its hooks and CodeMirror integration can support both versions. This change supports^18.3.1 || ^19.0.0, uses the automatic JSX runtime in tests, and adds a CI matrix for React/React DOM 18.3.1, 19.0.0, and 19.3.1 with matching React types. Each job verifies the actual loaded runtime version and type-checks the wrapper.Lifecycle regressions found during compatibility testing are fixed too: deleting or clearing a cache now destroys its CodeMirror views, and component cleanup safely detaches the captured DOM node. A mounted provider still preserves edits when switching files; standalone editors and unmounted providers dispose their views. The README documents ownership and disposal, and a Changeset covers the React wrapper and core package.
Validation:
pnpm buildpassed, including Vite, Next.js, and Vue playgrounds.pnpm exec jest --runInBand: 11 suites / 40 tests passed.git diff --checkpassed.This compatibility claim is limited to the SQL editor. It does not upgrade the playgrounds or establish React 19 support for unrelated UIKit dependencies. Existing Rollup external-dependency and TS5096 warnings remain unchanged.