Skip to content

feat(platform): validate IBM Bob in real clients#656

Draft
tirth8205 wants to merge 1 commit into
mainfrom
codex/validate-ibm-bob-real-client
Draft

feat(platform): validate IBM Bob in real clients#656
tirth8205 wants to merge 1 commit into
mainfrom
codex/validate-ibm-bob-real-client

Conversation

@tirth8205

@tirth8205 tirth8205 commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Latest refresh — 18 July 2026

  • rebased patch-identically onto main 0a3bd6c; current head 9f07ae4
  • all 15 hosted checks passed after this rebase
  • Bob Shell and Bob IDE are not installed here; this stays draft and is not mergeable by policy## Status

Draft — do not merge until the real-client checks below pass.

This re-stages the safe IBM Bob portion of PR #540 after it was reverted from main because only automated configuration tests had been run. The original contributor remains credited.

Change

  • install the MCP server for Bob Shell at its documented user configuration path
  • install the MCP server for Bob IDE at its documented project configuration path
  • use command-based STDIO entries
  • preserve unrelated configuration during install, reinstall, and uninstall
  • document both clients

Automated validation

  • IBM Bob install/skills tests: 189 passed
  • complete non-daemon suite: 1,913 passed, 1 skipped, 2 expected deselections, 2 xpassed
  • both multiprocessing parity checks: 2 passed
  • Ruff and git diff --check: clean

Required real-client validation

Do not mark this ready or merge it until all items below are recorded with the released applications:

  • Bob Shell discovers the generated MCP server without configuration errors
  • Bob Shell invokes a code-review-graph tool successfully
  • Bob IDE discovers the project MCP server without configuration errors
  • Bob IDE invokes a code-review-graph tool successfully
  • reinstall/upgrade preserves unrelated Bob MCP entries in both clients
  • uninstall removes only code-review-graph and both clients still load their remaining MCP configuration

Carries the safe intent of PR #540 with mohan-kumar-m2 preserved as co-author.

@github-actions

Copy link
Copy Markdown

code-review-graph review

Overall risk: 0.55 (MEDIUM) — 11 changed function(s)/class(es), 0 affected flow(s), 3 test gap(s)

Risk-scored changes

Risk Level Symbol Location Tested
0.55 medium code_review_graph/skills.py::install_platform_configs code_review_graph/skills.py:433 no
0.45 medium tests/test_skills.py::TestBobPlatforms.test_all_does_not_create_bob_files_without_detection_signal tests/test_skills.py:1662 (test)
0.30 low tests/test_cli_install.py::test_platform_choices_use_current_bob_product_names tests/test_cli_install.py:101 (test)
0.30 low tests/test_skills.py::TestBobPlatforms.test_bob_platform_entries_follow_current_ibm_contracts tests/test_skills.py:1566 (test)
0.30 low tests/test_skills.py::TestBobPlatforms.find_executable tests/test_skills.py:1647 no
0.25 low tests/test_skills.py::TestBobPlatforms tests/test_skills.py:1563 no
0.25 low tests/test_skills.py::TestBobPlatforms.test_install_bob_shell_uses_global_settings_without_stdio_type tests/test_skills.py:1580 (test)
0.25 low tests/test_skills.py::TestBobPlatforms.test_install_bob_ide_uses_project_settings_without_stdio_type tests/test_skills.py:1593 (test)
0.25 low tests/test_skills.py::TestBobPlatforms.test_bob_install_preserves_existing_servers_and_is_idempotent tests/test_skills.py:1605 (test)
0.25 low tests/test_skills.py::TestBobPlatforms.test_all_detects_bob_ide_from_workspace_directory tests/test_skills.py:1628 (test)

Test gaps

  • code_review_graph/skills.py::install_platform_configs (code_review_graph/skills.py:433)
  • tests/test_skills.py::TestBobPlatforms (tests/test_skills.py:1563)
  • tests/test_skills.py::TestBobPlatforms.find_executable (tests/test_skills.py:1647)

Token savings: this graph-backed report used ~88,860 fewer tokens (~97%) than reading every changed file in full (estimated, chars/4 approximation).


Powered by code-review-graph — local-first analysis; no code leaves the CI runner.

Keep this draft unmerged until both Bob Shell and Bob IDE discover the generated MCP configuration, invoke code-review-graph successfully, and pass reinstall and uninstall checks in the real applications.

Co-authored-by: mohan-kumar-m2 <243704502+mohan-kumar-m2@users.noreply.github.com>
@tirth8205
tirth8205 force-pushed the codex/validate-ibm-bob-real-client branch from 479ea6f to 9f07ae4 Compare July 17, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant