Repository navigation
Conversation
tobocop2
force-pushed
the
refactor/cli-shared-helpers
branch
2 times, most recently
from
September 28, 2026 07:20
3214426 to
5101885
Compare
tobocop2
force-pushed
the
fix/settings-write-lock
branch
from
September 28, 2026 08:09
7a2be62 to
c7bb145
Compare
tobocop2
force-pushed
the
refactor/cli-shared-helpers
branch
from
September 28, 2026 08:09
5101885 to
636b87c
Compare
analyze.py and dataset.py carried their own copies of the failure and line helpers that PR #974 already extracted into cli/commands/_shared.py for profile.py and settings.py. Import the shared fail() and line() instead and drop the local copies.
tobocop2
force-pushed
the
fix/settings-write-lock
branch
from
September 28, 2026 18:42
c7bb145 to
eb1d86d
Compare
tobocop2
force-pushed
the
refactor/cli-shared-helpers
branch
from
September 28, 2026 18:42
636b87c to
a4e6527
Compare
Owner
Author
|
This change is now part of #1003, which collects every Profiles pull request on one branch. Review and merge happen there. The branch stays in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
analyzeanddatasetcommands kept their own copies of the error and line-printing helpers after the other profile commands moved to one shared set.Solution
Both commands now use the shared helpers. Their output and exit codes are unchanged in both normal and
--jsonmode, checked byte for byte before and after.