Repository navigation
Conversation
PR #984 added a direct-child scan in app.py so the fleet and sessions drawer checks skip screen.query()'s whole-subtree walk. The chat screen's Tab-into-fleet handler still used query(), so it paid the same cost the app-level checks were built to avoid. Move the lookup to widgets/drawer.py, the module both app.py and chat.py already import from for the Drawer base class, and point both at the shared helper. No behaviour change.
tobocop2
force-pushed
the
fix/profile-warning-source
branch
from
September 28, 2026 18:42
bfa9c6d to
9cfec29
Compare
tobocop2
force-pushed
the
refactor/chat-fleet-drawer-lookup
branch
from
September 28, 2026 18:42
2f5768c to
94f8488
Compare
Owner
Author
|
This change is now part of #1003, which collects every Profiles pull request on one branch. Review and merge happen there. The branch stays in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pressing Tab in chat to move into the fleet drawer still searched the whole screen for the drawer, while every other drawer check had moved to a lookup over the screen's direct children.
Solution
The direct-child lookup now lives with the drawer widgets and every drawer check uses it, including the Tab handler in chat. Behaviour is unchanged.