Repository navigation
build(before-code-freeze): Align CMake configuration with the other repos (#162) - #164
Merged
mc-nv merged 1 commit intoSep 2, 2026
Conversation
…epos (#162) * build: Align with other Cmake configuration * fix: Use Python3_EXECUTABLE for the gRPC Python codegen cd84eea switched the lookup to find_package(Python3 ...) but left the custom command on ${Python_EXECUTABLE}, which that package never populates. The variable expands to empty, so the grpc_tools.protoc command runs with no interpreter and grpc-service-py-library cannot generate its output. TRITON_COMMON_ENABLE_PROTOBUF_PYTHON defaults to ON, so this is on the default build path rather than an opt-in one. Only Interpreter is requested, which is all the codegen needs. (cherry picked from commit 3cafdb6)
This was referenced Sep 1, 2026
Merged
mc-nv
marked this pull request as ready for review
September 1, 2026 19:19
Greptile SummaryCorrects gRPC Python code generation to use the interpreter variable populated by CMake’s Python3 package discovery.
Confidence Score: 5/5The PR appears safe to merge, with the interpreter command now matching the CMake package used for discovery. The changed code consistently uses Important Files Changed
Reviews (1): Last reviewed commit: "build(before-code-freeze): Align CMake c..." | Re-trigger Greptile |
yinggeh
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
r26.08ontomain.Python3_EXECUTABLEfor the gRPC Python codegen;Python_EXECUTABLEis never populated byfind_package(Python3), so the codegen ran with no interpreter.TRITON_COMMON_ENABLE_PROTOBUF_PYTHONdefaults to ON, so this is the default build path.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
protobuf/CMakeLists.txt— the two-line variable fix.Test plan:
Full CI run on the internal pipeline at
TRITON_CONTAINER_VERSION=26.09dev_user, withTRITON_NIGHTLY=1andTRITON_SBSA=1.Local verification: per-repo
pre-commit run --files <changed>passes with no auto-fixes.CI Pipeline ID:
Caveats:
TRITON_SERVER_MODEL_REPO_VERSIONderives fromTRITON_CONTAINER_VERSION, so26.09devmust exist on the share first.Background
Post-release step of the 26.08 train: the default branches move onto the same upstream containers as the just-released
r26.08, and pick up the fixes that landed only on the release branch while it stabilised.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)