Skip to content

build(before-code-freeze): Align CMake configuration with the other repos (#162) - #164

Merged
mc-nv merged 1 commit into
mainfrom
mchornyi/TRI-1691/before-ngc-release-advance-master-branch-to-next-upstream-release
Sep 2, 2026
Merged

mc-nv merged 1 commit into
mainfrom
mchornyi/TRI-1691/before-ngc-release-advance-master-branch-to-next-upstream-release

Conversation

@mc-nv

@mc-nv mc-nv commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

What does the PR do?

  • Carries the CMake alignment forward from r26.08 onto main.
  • Uses Python3_EXECUTABLE for the gRPC Python codegen; Python_EXECUTABLE is never populated by find_package(Python3), so the codegen ran with no interpreter.
  • TRITON_COMMON_ENABLE_PROTOBUF_PYTHON defaults to ON, so this is the default build path.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

protobuf/CMakeLists.txt — the two-line variable fix.

Test plan:

  • Full CI run on the internal pipeline at TRITON_CONTAINER_VERSION=26.09dev_user, with TRITON_NIGHTLY=1 and TRITON_SBSA=1.

  • Local verification: per-repo pre-commit run --files <changed> passes with no auto-fixes.

  • CI Pipeline ID:

Caveats:

  • Do not merge before the model-repository mount point is rotated: TRITON_SERVER_MODEL_REPO_VERSION derives from TRITON_CONTAINER_VERSION, so 26.09dev must exist on the share first.

Background

Post-release step of the 26.08 train: the default branches move onto the same upstream containers as the just-released r26.08, and pick up the fixes that landed only on the release branch while it stabilised.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: TRI-1691

…epos (#162)

* build: Align with other Cmake configuration

* fix: Use Python3_EXECUTABLE for the gRPC Python codegen

cd84eea switched the lookup to find_package(Python3 ...) but left the
custom command on ${Python_EXECUTABLE}, which that package never
populates. The variable expands to empty, so the grpc_tools.protoc
command runs with no interpreter and grpc-service-py-library cannot
generate its output.

TRITON_COMMON_ENABLE_PROTOBUF_PYTHON defaults to ON, so this is on the
default build path rather than an opt-in one.

Only Interpreter is requested, which is all the codegen needs.

(cherry picked from commit 3cafdb6)
@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Greptile Summary

Corrects gRPC Python code generation to use the interpreter variable populated by CMake’s Python3 package discovery.

  • Replaces find_package(Python ...) with find_package(Python3 ...).
  • Invokes grpc_tools.protoc through Python3_EXECUTABLE.

Confidence Score: 5/5

The PR appears safe to merge, with the interpreter command now matching the CMake package used for discovery.

The changed code consistently uses find_package(Python3) and Python3_EXECUTABLE, correcting the previously empty interpreter invocation without altering generated interfaces or package exports.

Important Files Changed

Filename Overview
protobuf/CMakeLists.txt Aligns Python interpreter discovery and invocation for gRPC Python code generation; no actionable defects identified.

Reviews (1): Last reviewed commit: "build(before-code-freeze): Align CMake c..." | Re-trigger Greptile

@mc-nv
mc-nv merged commit fd2237e into main Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system or external dependencies (build: PRs) cherry-pick Cherry-picked from another branch

Development

Successfully merging this pull request may close these issues.

2 participants