Repository navigation
docs: Add SECURITY.md - #85
Conversation
TRI-1935
|
TRI-1935
|
|
||
| 1. **Not hardened:** Examples and modified third-party sources are for development and reference, and may omit production security controls. | ||
| 2. **Vulnerable or outdated dependencies:** Bundled or referenced third-party code may contain known vulnerabilities or lag behind upstream fixes. | ||
| 3. **Supply chain:** Sources and models fetched at build or run time may be tampered with or unpinned. |
There was a problem hiding this comment.
Mutable tag risk obscured The new description warns that fetched sources may be “unpinned,” but most dependencies are pinned by Git tags that can be retargeted. The build does not verify signatures or checksums, so a retargeted tag could change the code built without a version change. Omitting this distinction makes the actual supply-chain risk harder to assess.
| ## Critical Security Assumptions | ||
|
|
||
| * The code is used for development and evaluation, and is reviewed before any production use. | ||
| * Deployers add authentication, authorization and TLS before exposing services. |
There was a problem hiding this comment.
TLS build constraint omitted The advice to add TLS before exposing services omits that the vendored HTTP library is built with SSL disabled. Triton consumers therefore need external TLS termination and their own request limits and timeouts. Without that context, the deployment guidance is less useful for safely using this library.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
What does the PR do?
SECURITY.md, which this repository did not have. Flagged by an AIVO asset review.NVIDIA/NeMo,cuda-pythonandMegatron-LM. Text is NVIDIA-authored, unmodified except the platform-neutral "GitHub/GitLab" wording fromcuda-python.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
SECURITY.md— compare againstNVIDIA/NeMo/SECURITY.mdfor the canonical wording.Test plan:
Documentation only; no code paths affected.
CI Pipeline ID:
Caveats:
NVIDIA/NeMosays "through GitHub",NVIDIA/cuda-pythonsays "through GitHub/GitLab". This PR uses the latter because Triton repositories exist on both GitHub and internal GitLab.Background
An AIVO asset review (securityportal.nvidia.com/aivo/assets) flagged Triton repositories with no SECURITY.md. Rather than authoring per-repository security documentation, every repository adopts NVIDIA's current standard template so the policy is identical everywhere and carries no repository-specific claims to maintain.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)