Repository navigation
Stabilize CI browser tests on macOS and Windows runners - #223
Merged
Merged
Conversation
- SE_SKIP_DRIVER_IN_PATH: runner images ship a chromedriver on PATH
that lags the installed Chrome, so Selenium Manager picked a
mismatched driver ('ChromeDriver only supports Chrome version 152')
and macOS Chrome tests failed or were silently skipped
- Pass --no-sandbox/--disable-dev-shm-usage to every Requestium-launched
Chrome in tests via own_chrome_session(), as the conftest drivers
already did. On Windows runners, sandboxed Chrome for Testing
(selected by selenium 4.32's Selenium Manager) silently drops
navigations: measured 21/30 OK sandboxed vs 30/30 with --no-sandbox
- Widen test_session_default_timeout_is_used's margin; it missed by
20ms on a slow Ubuntu runner
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01446x2ZH4bs3pKQ6mV84K1a
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets the full CI matrix green. Root causes were found with a throwaway debug workflow on a scratch branch, running launch probes on the real runners.
/usr/local/bin/chromedriver(152) is on PATH and Selenium Manager prefers it over a matching driver, so Chrome 154 launches failed with "ChromeDriver only supports Chrome version 152". Some of those tests were being silently skipped rather than failed. Fixed withSE_SKIP_DRIVER_IN_PATH: true(25/25 launches OK on both resolutions afterwards).driver.get()sometimes returns while the page stays ondata:,(21/30 OK). With--no-sandboxit was 30/30. The conftest drivers already passed that flag. Now every Requestium-launched Chrome in the tests gets it too, through a newown_chrome_session()helper. The library itself stays sandboxed.🤖 Generated with Claude Code
https://claude.ai/code/session_01446x2ZH4bs3pKQ6mV84K1a