Repository navigation
Conversation
$enable-cssgrid defaults to true since v6 (scss/_config.scss), so the CSS Grid classes ship enabled. Update the css-grid and grid utilities pages, which still said the system is opt-in and disabled by default, and reword the instructions to describe how to disable it instead.
julien-deramond
added
v6
Contributor
Author
|
Branch is behind |
Member
|
Please don't rebase each time there are modifications in `main' (except if there are conflicts to handle). Otherwise it generates notifications and potential CI run for nothing :) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v6 docs still describe the CSS Grid system as opt-in and "disabled by default", but
$enable-cssgridhas defaulted totruesince the v6 alpha (scss/_config.scss:36:$enable-cssgrid: true !default;), so the.gridclasses ship enabled. This PR updates the three stale statements to say the system is enabled by default and explains how to disable it instead:site/src/content/docs/layout/css-grid.mdx— the warning callout, the "optional grid system" sentence and the first "How it works" bullet, plus the frontmatter description ("Learn how to enable…").site/src/content/docs/utilities/grid.mdx— the info callout.The
$enable-cssgridrow in the options table (customize/options.mdx) is intentionally not touched here, since #42427 already covers it.Motivation & Context
A user following the current docs would set
$enable-cssgrid: truebelieving they are enabling an optional feature, when the grid is already active in their build. Verified against the shipped v6.0.0-alpha.1 dist CSS, which contains the.gridclasses.Type of changes
Checklist
npm run lint)Testing
Docs-only change. Verified
$enable-cssgrid: true !default;inscss/_config.scss, thatscss/layout/_grid.scssgates.gridgeneration on it, and that no open PR covers these two files (#42427 only touchescustomize/options.mdx; #42784 refactors grid mechanics without touching the opt-in text).