Skip to content

docs: keep the v5 navbar logo inside the versioned docs - #43250

Closed
ump45nose wants to merge 1 commit into
twbs:v5-devfrom
ump45nose:fix-43080-v5-docs-logo-href
Closed

ump45nose wants to merge 1 commit into
twbs:v5-devfrom
ump45nose:fix-43080-v5-docs-logo-href

Conversation

@ump45nose

Copy link
Copy Markdown
Contributor

Description

The docs navbar brand used href="/". On getbootstrap.com that opens the site root, which is now the v6 homepage. A click on the logo in the v5 docs left the v5 docs.

Point the brand at the versioned docs root via getVersionedDocsPath("/") so it stays on /docs/5.3/.

Fixes #43080

Motivation & Context

Users who read the v5 docs and click the logo should stay in those docs.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of this project
    • My change requires a change to the documentation
    • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

AI disclosure

AI-assisted change. I verified the brand link target and the issue report.

The brand link used href="/" so a click on the v5 docs logo opened the
site root (now the v6 homepage). Point it at the versioned docs root
instead (Fixes twbs#43080).
@julien-deramond

Copy link
Copy Markdown
Member

We haven't decided yet what will be the modification, if any. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants