Repository navigation
Fix Menu event listeners and touch memory leak on dispose - #43253
Open
ShakilUrRehman21 wants to merge 1 commit into
Open
ShakilUrRehman21 wants to merge 1 commit into
ShakilUrRehman21 wants to merge 1 commit into
Conversation
julien-deramond
added
v6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes memory leaks in the Menu component when
dispose()is called:this._menu: In_setupSubmenuListeners(), event listeners (mouseenter,mouseleave,mousemove,click) were registered without namespacing.dispose()did not remove listeners onthis._menu.document.body.children: If disposed while open on a touch device,mouseoverlisteners ondocument.body.childrenwere never removed.Changes
this._menuwithEVENT_KEY.dispose(), callEventHandler.off(this._menu, EVENT_KEY).dispose(), remove touchmouseoverlisteners fromdocument.body.children.dispose()removes listeners from_menuand cleans up touch listeners.